[WG: Sakai QA] [Building Sakai] 2.6.x build is broken

[Jean-Francois Leveque]

+1 on thanking Karen

J-F

Anthony Whyte a écrit :
> Thanks Karen.  Much appreciated.
> 
> Anth
> 
> 
> On May 12, 2010, at 2:41 PM, Karen Tsao wrote:
> 
>> I have fixed the issue and 2.6.x is built successfully in my local. 
>> Sorry that I broke the build. I will make sure to build it before 
>> commit all the time.
>>
>> Thanks,
>> Karen
>>
>> On Wed, May 12, 2010 at 6:23 AM, Jean-Francois Leveque 
>> <jean-francois.leveque at upmc.fr <mailto:jean-francois.leveque at upmc.fr>> 
>> wrote:
>>
>>     +1 to get the "build before commit" rule official and written for .x
>>     branches
>>     -1 for penalty so far
>>
>>     How often does Hudson build the .x branches?
>>
>>     DAVID ROLDAN MARTINEZ a écrit :
>>     > +1
>>     >
>>     > -----Mensaje original-----
>>     > De: sakai-dev-bounces at collab.sakaiproject.org
>>     <mailto:sakai-dev-bounces at collab.sakaiproject.org>
>>     [mailto:sakai-dev-bounces at collab.sakaiproject.org
>>     <mailto:sakai-dev-bounces at collab.sakaiproject.org>] En nombre de
>>     Aaron Zeckoski
>>     > Enviado el: miércoles, 12 de mayo de 2010 14:16
>>     > Para: Jean-Francois Leveque
>>     > CC: Sakai QA; sakai-dev Developers
>>     > Asunto: Re: [Building Sakai] 2.6.x build is broken
>>     >
>>     > Ideally, everyone who has commit access would always test the builds
>>     > before making commits. In my opinion that is the least any of us
>>     > should be doing. This is especially true of the .x branches.
>>     > There are going to be times when a local build succeeds and it is
>>     > broken for others but that is what the hudson server should be
>>     > detecting. In that case, the "taskforce" is the person who broke
>>     it in
>>     > my opinion.
>>     >
>>     > If things get really bad then we might need to penalize people for
>>     > breaking builds repeatedly (maybe with loss of commit
>>     privileges) but
>>     > I hope that would not be necessary.
>>     >
>>     > -AZ
>>     >
>>     >
>>     >
>>     > On Wed, May 12, 2010 at 12:42 PM, Jean-Francois Leveque
>>     > <jean-francois.leveque at upmc.fr
>>     <mailto:jean-francois.leveque at upmc.fr>> wrote:
>>     >> Should we have a policy to deal with broken builds?
>>     >>
>>     >> Some time ago, I broke the 2.5.x build and I broke trunk not so
>>     long
>>     >> ago. Sometimes doing things quickly leads to a broken build.
>>     >>
>>     >> How long do we want trunk, the next version branch or a maintenance
>>     >> branch to have a broken build (time may differ in each case)?
>>     >>
>>     >> Should a build task force across time zones be ready to get
>>     builds back
>>     >> to working?
>>     >>
>>     >> A build can even be partly unusable without the build been broken.
>>     >>
>>     >> How often should we run the expected automated functional
>>     testing on builds?
>>     >>
>>     >> Jean-Francois
>>     >>
>>     >> Steve Swinsburg a écrit :
>>     >>> Hi all,
>>     >>>
>>     >>> The 2.6.x build is broken:
>>     >>>
>>     >>> [ERROR] BUILD FAILURE
>>     >>> [INFO]
>>     ------------------------------------------------------------------------
>>     >>> [INFO] Compilation failure
>>     >>>
>>     /Users/steve/dev/sakai/src/2.6.x/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacadeQueries.java:[119,7]
>>     org.sakaiproject.tool.assessment.facade.PublishedAssessmentFacadeQueries
>>     is not abstract and does not override abstract method
>>     getPublishedAssessment(java.lang.Long,boolean) in
>>     org.sakaiproject.tool.assessment.facade.PublishedAssessmentFacadeQueriesAPI
>>     >>>
>>     >>> Due to:
>>     >>> http://jira.sakaiproject.org/browse/SAM-696
>>     >>>
>>     >>> >From the commits, the trunk and branch merges don't match and
>>     the branch is missing a method.
>>     >>>
>>     >>>
>>     >>> Steve
>>     >> _______________________________________________
>>     >> sakai-dev mailing list
>>     >> sakai-dev at collab.sakaiproject.org
>>     <mailto:sakai-dev at collab.sakaiproject.org>
>>     >> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>     >>
>>     >> TO UNSUBSCRIBE: send email to
>>     sakai-dev-unsubscribe at collab.sakaiproject.org
>>     <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
>>     subject of "unsubscribe"
>>     _______________________________________________
>>     sakai-dev mailing list
>>     sakai-dev at collab.sakaiproject.org
>>     <mailto:sakai-dev at collab.sakaiproject.org>
>>     http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>>     TO UNSUBSCRIBE: send email to
>>     sakai-dev-unsubscribe at collab.sakaiproject.org
>>     <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
>>     subject of "unsubscribe"
>>
>>
>> _______________________________________________
>> sakai-qa mailing list
>> sakai-qa at collab.sakaiproject.org <mailto:sakai-qa at collab.sakaiproject.org>
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-qa
>>
>> TO UNSUBSCRIBE: send email to 
>> sakai-qa-unsubscribe at collab.sakaiproject.org with a subject of 
>> "unsubscribe"
>