[sakai-pmc] [Building Sakai] Re-proposing - Edia skin manager for Sakai 10

Sat Dec 21 12:55:54 PST 2013

I have performed a bit of a code review and have identified a couple of
issues that will need to be resolved.

1. Trunk build fails:

ERROR] Failed to execute goal
org.codehaus.mojo:license-maven-plugin:1.5:check-file-header (default) on
project edia-sakai-skinmanager: Execution default of goal
org.codehaus.mojo:license-maven-plugin:1.5:check-file-header failed: Plugin
org.codehaus.mojo:license-maven-plugin:1.5 or one of its dependencies could
not be resolved: Failure to find org.sakaiproject.license:ecl-2:jar:1.0 in
http://source.sakaiproject.org/maven2 was cached in the local repository,
resolution will not be reattempted until the update interval of Sakai
Plugin Repo has elapsed or updates are forced -> [Help 1]

2. There don't appear to be any database indexes on the tables it creates.

3. The app performs SQL queries outside of its own tables (ie select from
sakai_site). I doubt the sakai_site schema will change but this is
something to be aware of.

4. The POMs list the Edia maven repo. This is because the app requires
edia-sakai-utils which is a separate project. It is in SVN as a separate
module. This will need to have something done with it. We also don't want
to depend on additional repositories as we have worked to remove them.

5. The edia-sakai-utils library is copyright to Edia so if this was to be
pulled into core it will need to have its license changed as well.

<dependency>
      <groupId>nl.edia</groupId>
      <artifactId>edia-sakai-utils</artifactId>
    </dependency>

I have not performed any review of the util library. I don't think its
acceptable that because a project depends on other libraries that they are
also pulled into the Sakai source. If this library was deployed to Maven
central as a binary, that would be fine.

6. The shared-deploy/pom.xml deploys jstl and taglib deps to shared. This
will need to be refactored as required.

7. The tool description for skin selector will need to be made generic,
currently it is 'Skin Selector by Edia Educatie Technologie (
http://www.edia.nl)'

8. The tool description for skin manager will need to be made generic,
currently it is 'Skin Manager by Edia Educatie Technologie (
http://www.edia.nl)'

9. Some buttons are hardcoded (ie Yes, No).

Because of these issues, I am reluctantly voting -1. If these can be
resolved then I will happily change my vote.

I also request that the discussion period on this tool be extended to give
others input on my findings.

regards,
Steve

On Sat, Dec 21, 2013 at 12:39 AM, Neal Caidin <neal.caidin at apereo.org>wrote:

> Hi,
>
> I haven't seen any objections to the Edia Skin Manager being added? Today
> is the last day for comments.
>
> Yesterday at the Sakai release meeting, Earle said that AsahiNet (ANI)
> clients having been using the skin manager in production for a while.
>
> Thanks,
> Neal
>
>
>   Anthony Whyte <arwhyte at umich.edu>
>  December 18, 2013 at 9:38 AM
> I'm reviewing the license change today and will confer with the Apereo
> Licensing WG regarding next steps, if any.
>
> anthony whyte | its and mlibrary | university of michigan |
> arwhyte at umich.edu | 517-980-0228
>
>
>
>
>   Neal Caidin <neal.caidin at apereo.org>
>  December 18, 2013 at 8:48 AM
>  * Precondition sounds like it is met.
>
> * Incubation, at this point, sounds optional.
>
> * Voting does not seem required.
>
> Therefore, please provide comments by Friday, Dec 20 for a final decision
> on this proposal.
>
> Thanks,
> Neal
>
>
>
>
>   Roland Groen <roland at edia.nl>
>  December 16, 2013 at 8:36 PM
> Hi,
>
> The license change from GNU Lesser General Public License to ECLv2 has
> been done,
> pls 
> check https://jira.sakaiproject.org/browse/SM-21 and the skin manager
> trunk / 4.2.1
>  @ https://source.sakaiproject.org/contrib/edia/skin-manager/
> .
>
> Cheers
> ,
>
> --
> *Roland Groen*
> roland at edia.nl
>
> *EDIA B.V.*
> Egelantiersstraat 143  |  1015 RA Amsterdam
> *T* +31 (0)20 716 36 12 | *F* +31 (0)20 716 36 13 | *M* +31 (0)6 24 23
> 0906
> Wij creëren educatietechnologie omdat goed onderwijs essentieel is  |  We
> create relevant education technology
> www.edia.nl
>
>
>
>   Neal Caidin <neal.caidin at apereo.org>
>  December 16, 2013 at 10:39 AM
> > License.  Yes, changing the license is a pre-condition to moving the
> code from contrib to core.  Change the license first, then consider
> promotion.
>
> What if the proposal acceptance became contingent on completing the
> license change by a certain date, for example, before January 17, 2014?
>
> Thanks,
> Neal
>
>
>
> Neal Caidin
> Sakai Community Coordinator
> neal.caidin at apereo.org
> Skype: nealkdin
> Twitter: ncaidin
>
>
>
>
>
>
>
>
>
>
>
>   Anthony Whyte <arwhyte at umich.edu>
>  December 16, 2013 at 8:36 AM
> Three opinions.
>
> License.  Yes, changing the license is a pre-condition to moving the code
> from contrib to core.  Change the license first, then consider promotion.
>  Second, the only code we should consider moving is skin-manager trunk.  We
> leave the rest in contrib.  The tags can't be relicensed: they represent
> frozen artifacts and cannot be changed.  I would leave the branch code
> behind as well and untouched as regards the license. (2.4.x to 2.7.x;
> SM1-SM7).  Yes, if trunk history is retained checking out an earlier
> revision would unmask the old license.  If this is a concern, then leave
> the history behind by performing an svn export of skin manager trunk and
> start with a clean directory tree.
>
> Formal Incubation.  I think it overkill in this case.  Quite likely the
> paperwork/review process alone will doom it for 10.  [1]
>
> Voting.  I don't see why skin-manager requires a formal vote of the PMC.
>  Other than the licensing issue (a blocker) it's suggested inclusion is no
> different than earlier lazy consensus proposals made on behalf of
> capabilities such as roster2.  If members of the Sakai team (a.k.a., the
> release team) which also includes PMC members think skin-manager inclusion
> inappropriate for 10 they will push back.
>
> Cheers,
>
> Anth
>
> [1] http://www.apereo.org/content/s3-core-process
>
>
> anthony whyte | its and mlibrary | university of michigan |
> arwhyte at umich.edu | 517-980-0228
>
>
>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
>
> --
> Neal Caidin
> Sakai Community Coordinator
> Apereo Foundation
> neal.caidin at apereo.org
> Skype me! (but let me know in advance for the first interaction) - nealkdin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-pmc/attachments/20131222/72e97e0e/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 770 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-pmc/attachments/20131222/72e97e0e/attachment.jpe 