[Building Sakai] smtpFrom at org.sakaiproject.email.api.EmailService property
Miguel Carro Pellicer
mcarro at entornosdeformacion.com
Sun Mar 29 23:45:52 PDT 2015
Thanks Matthew,
The ticket SAK-23242 is not mine, another user with the same firstname :)
I created https://jira.sakaiproject.org/browse/KNL-1341 to accept null
values in the fromStr variable.
Then i will raise some Jiras to cleanup the value from the tools and use
the same property, personally i do not like "setup.request" but this
will guarantee the compatibility in many institutions. Do we need to
still support the different set of properties
(fromEmailAddress at org.sakaiproject.poll.logic.ExternalLogic
<mailto:fromEmailAddress at org.sakaiproject.poll.logic.ExternalLogic>,
msgcntr.notification.from.address, etc) ?
Regards, Miguel
El 27/03/2015 a las 15:36, Matthew Jones escribió:
> I know this is a problem and has been one for awhile but I don't think
> the spring bean style property should be the value used as the lookup
> for this.in <http://this.in> the tool level. I don't even think that
> the tools should be required to provide any from address at all. I'd
> probably just change BasicEmailService to make the "fromStr" optional
> (accept null) and use whatever is in smtpFrom as the default if not
> provided. And then just clean it up everywhere else that tries to set
> it to some default.
>
> There's an open jira for using setup.request as the default for all
> tools that need a from address. (A ticket that I believed you opened)
> https://jira.sakaiproject.org/browse/SAK-23242
>
> But this issue goes all the way back to 2008
> https://jira.sakaiproject.org/browse/SAK-13910
>
> When I did research on it, I'd found that a number of properties were
> in use
> smtpFrom at org.sakaiproject.email.api.EmailService
> <mailto:smtpFrom at org.sakaiproject.email.api.EmailService> (for kernel)
> fromEmailAddress at org.sakaiproject.poll.logic.ExternalLogic
> <mailto:fromEmailAddress at org.sakaiproject.poll.logic.ExternalLogic> (for
> polls)
> setup.request (in site-manage)
> msgcntr.notification.from.address (in msgcntr if
> msgcntr.notification.user.real.from is false)
> setup.request in OSP
>
> In addition to the
> "no-reply" +
> pattern there's also a lot of
> "postmaster" +
> patterns
>
>
> On Fri, Mar 27, 2015 at 9:19 AM, Paul Lukasewych <plukasew at uwo.ca
> <mailto:plukasew at uwo.ca>> wrote:
>
> +1
>
> We have run into this at our institution as well. A single from
> address
> controlled via a property should be used in all cases.
>
> Paul Lukasewych
> Applications Development Team
> Information Technology Services
> Support Services Building
> Western University
> (519) 661-2111 x80513 <tel:%28519%29%20661-2111%20x80513>
> plukasew at uwo.ca <mailto:plukasew at uwo.ca>
>
> On 2015-03-27 07:40 AM, Miguel Carro Pellicer wrote:
> > Hi subscribers,
> >
> > I want to ask something about the
> > "smtpFrom at org.sakaiproject.email.api.EmailService" property,
> this is a property
> > to set the "from" address of outgoing emails.
> >
> > I noticed a lot of Sakai logic does not use this property, uses
> code like:
> >
> > String userEmail = "no-reply@" +
> ServerConfigurationService.getServerName();
> >
> > or
> >
> > return "From: " + "\"" +
> m_serverConfigurationService.getString("ui.service",
> > "Sakai") + "\"<no-reply@"+
> m_serverConfigurationService.getServerName() + ">";
> >
> > This works fine when you have the no-reply at XXX account in your
> institution, but
> > doesn't work properly when you have another address.
> >
> > IMHO Sakai should use the smtpFrom property and use this logic
> as a fallback, i
> > created some Jiras but i don't know if the community thinks the
> same.
> >
> > https://jira.sakaiproject.org/browse/SAK-29204
> > https://jira.sakaiproject.org/browse/SAK-29143
> > https://jira.sakaiproject.org/browse/SAK-29209
> >
> > ... and many many tools like Samigo, Assessments,
> Announcements... if i create
> > the no-reply at XXXX account at my institution i will finish earlier :D
> >
> > If my approach is correct i can continue creating Jiras, testing
> and creating
> > pull requests about this.
> >
> > Thanks in advance, Miguel
> > --
> > Miguel Carro Pellicer
> > Logo
> >
> > Miguel Carro
> Pellicer<http://es.linkedin.com/pub/miguel-carro-pellicer/38/502/b92>
> > /CTO Entornos de Formación S.L./
> >
> > Phone: +34 - 686266485 <tel:%2B34%20-%20686266485>
> > Email: mcarro at entornosdeformacion.com
> <mailto:mcarro at entornosdeformacion.com>
> <mailto:mcarro at entornosdeformacion.com
> <mailto:mcarro at entornosdeformacion.com>>
> >
> > No me imprimas si no es necesario. Protejamos el medio ambiente
> >
> >
> > AVISO LEGAL: El contenido de este mensaje de correo electrónico,
> incluidos los
> > ficheros adjuntos, es confidencial y está protegido por el
> artículo 18.3 de la
> > Constitución Española, que garantiza el secreto de las
> comunicaciones.
> > Si usted recibe este mensaje por error, por favor póngase en
> contacto con el
> > remitente para informarle de este hecho, y no difunda su
> contenido ni haga copias.
> > *** Este mensaje ha sido verificado con herramientas de
> eliminación de virus y
> > contenido malicioso ***
> > Este aviso legal ha sido incorporado automáticamente al mensaje.
> >
> >
> >
> > _______________________________________________
> > sakai-dev mailing list
> > sakai-dev at collab.sakaiproject.org
> <mailto:sakai-dev at collab.sakaiproject.org>
> > http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> >
> > TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org
> <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
> subject of "unsubscribe"
> >
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> <mailto:sakai-dev at collab.sakaiproject.org>
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org
> <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
> subject of "unsubscribe"
>
>
--
Miguel Carro Pellicer
Logo
Miguel Carro
Pellicer<http://es.linkedin.com/pub/miguel-carro-pellicer/38/502/b92>
/CTO Entornos de Formación S.L./
Phone: +34 - 686266485
Email: mcarro at entornosdeformacion.com
<mailto:mcarro at entornosdeformacion.com>
No me imprimas si no es necesario. Protejamos el medio ambiente
AVISO LEGAL: El contenido de este mensaje de correo electrónico,
incluidos los ficheros adjuntos, es confidencial y está protegido por el
artículo 18.3 de la Constitución Española, que garantiza el secreto de
las comunicaciones.
Si usted recibe este mensaje por error, por favor póngase en contacto
con el remitente para informarle de este hecho, y no difunda su
contenido ni haga copias.
*** Este mensaje ha sido verificado con herramientas de eliminación de
virus y contenido malicioso ***
Este aviso legal ha sido incorporado automáticamente al mensaje.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150330/0983c3e6/attachment.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: entornos_logo.jpg
Type: image/jpeg
Size: 8726 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150330/0983c3e6/attachment.jpg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linkedin.jpg
Type: image/jpeg
Size: 1103 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150330/0983c3e6/attachment-0001.jpg
More information about the sakai-dev
mailing list