[Building Sakai] What's your strategy for reviewing PRs?

[Steve Swinsburg]

Ok, got it, skipped over that 'commandline' link!

On Mon, Mar 2, 2015 at 11:18 PM, Matthew Buckett <
matthew.buckett at it.ox.ac.uk> wrote:

> You can just use:
>
> curl https://github.com/sakaiproject/sakai/pull/205.patch | patch
>
> Github has a help page about this:
>
> https://help.github.com/articles/checking-out-pull-requests-locally/
>
> which shows you how to checkout the pull request without having to clone
> the users repository.
> You can have git pull all pull requests from the Sakai repository
> automatically, but it doesn't cleanup closed pull requests.
> If you want todo this add line this to your .git/config file for the sakai
> remote in addition to the existing fetch:
>
>     fetch = +refs/pull/*/head:refs/remotes/origin/pull/*
>
>
>
> On 2 March 2015 at 12:06, Steve Swinsburg <steve.swinsburg at gmail.com>
> wrote:
>
>> Hi all,
>>
>> Just wondering what your strategy is for reviewing PRs? If its more than
>> a simple change I like to checkout and run it up to see it working, however
>> I find this very difficult with github PRs and remote forks as I need to
>> clone that user's repo in order to get the remote branch (or do I?) and
>> that typically takes an hour or more.
>>
>> What would be neat is if github could just give me a patch that I can
>> apply to my own fork, which I could then just reset.
>>
>> The scenario I am working from is this PR which I would like to review:
>> https://github.com/sakaiproject/sakai/pull/205/files
>>
>> cheers,
>> Steve
>>
>>
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>>
>
>
>
> --
>   Matthew Buckett, VLE Developer, IT Services, University of Oxford
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20150302/c3cd188f/attachment.html