[Building Sakai] ForumsEmailService does not respect smtpFrom property

[Miguel Carro Pellicer]

Hi Subscribers,

I noticed that the ForumsEmailService does not use the 
"smtpFrom at org.sakaiproject.email.api.EmailService" property to get the 
sender's email, instead of this makes this logic:

String fromEmailAddress = 
DiscussionForumTool.getResourceBundleString("email.fromAddress",
                   new 
Object[]{ServerConfigurationService.getString("serverName", "localhost")});

This causes that forums notifications does not work properly if you do 
not change the translation key. Is there any reason for this?

I changed the line to this and now works perfect:
String fromEmailAddress = 
ServerConfigurationService.getString("smtpFrom at org.sakaiproject.email.api.EmailService", 
"no-reply at localhost");

Thank you so much, Miguel
-- 
Miguel Carro Pellicer
Logo 	

Miguel Carro 
Pellicer<http://es.linkedin.com/pub/miguel-carro-pellicer/38/502/b92>
/IT Consultant - Elearning solutions/

Phone: +34 - 686266485
Email: miguel at educlever.es <mailto:miguel at educlever.es>

No me imprimas si no es necesario. Protejamos el medio ambiente


AVISO LEGAL: El contenido de este mensaje de correo electrónico, 
incluidos los ficheros adjuntos, es confidencial y está protegido por el 
artículo 18.3 de la Constitución Española, que garantiza el secreto de 
las comunicaciones.
Si usted recibe este mensaje por error, por favor póngase en contacto 
con el remitente para informarle de este hecho, y no difunda su 
contenido ni haga copias.
*** Este mensaje ha sido verificado con herramientas de eliminación de 
virus y contenido malicioso ***
Este aviso legal ha sido incorporado automáticamente al mensaje.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20140904/6d18d005/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: AF-BRAND---EDUCLEVER-01.jpg
Type: image/jpeg
Size: 17251 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20140904/6d18d005/attachment.jpg 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linkedin.jpg
Type: image/jpeg
Size: 1103 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20140904/6d18d005/attachment-0001.jpg