[Building Sakai] Sakai 10.2 Roster

igor Novopashenny Igor at escience.uni-bremen.de
Sat Oct 18 03:39:59 PDT 2014


Thank you for advice,

I’m trying to do it.

Now, I was working with the English language and got error in “Enrollment status”

/sakai-roster2-tool/lib/es5-shim.map

The requested resource is not available.

 

Regards Igor

 

Von: Juan José Meroño Sánchez [mailto:jjmerono at um.es] 
Gesendet: Samstag, 18. Oktober 2014 10:18
An: Bryan Holladay
Cc: igor Novopashenny; Sakai Development
Betreff: Re: [Building Sakai] Sakai 10.2 Roster

 

After more research on this issue I’ve found more related jiras:

 

In this jira I changed the way to load i18n strings using query-i18n to solve the problem, and also solved the problem with ‘ or “, after this jira you can write “ or ‘ without escape them.

 

https://jira.sakaiproject.org/browse/SAK-26290

 

After that, this jira back to the previous method of loading i18n properties to solve another problem.

 

https://jira.sakaiproject.org/browse/SAK-26260

 

The first jira was merged into 10.x but NOT the second one, (I’ve related your jira as depend on this one). Also if you check the boostrap.jsp file in 10.x branch you will see the difference, i18n property is empty !!

 

So, your solution only works for 11 version and the problem described by Igor in 10.2 can not be the same but is related !! In trunk version roster 2 is working properly with ru locale.

 

To solve your problem Igor you have to change your ui_ru.properties file to replace every \” with ” (removing the \) and this is going to solve your issue in 10.2.

 

I filed a new jira in order to solve the problem now in trunk (and maybe in 10.x if everything is merged).

 

https://jira.sakaiproject.org/browse/SAK-27993

 

For me the best solution is back to jquery-i18n adding the work done in SAK-26260 for server side to detect the current language properly.

 

Thanks !!

 

El 17/10/2014, a las 21:52, Bryan Holladay <holladay at longsight.com <mailto:holladay at longsight.com> > escribió:

 

Agreed, there needs to be a better way to catch all possible escapes. Can you just do something closer along the lines of escaping double quotes inside of double quotes? Also, I think it should go a step further. The Roster2 tool shouldn't fail because of a single JS error. 

 

On Fri, Oct 17, 2014 at 3:43 PM, Juan José Meroño Sánchez <jjmerono at um.es <mailto:jjmerono at um.es> > wrote:

Hi,

 

    I think your solution is not good enough, what about translations that include ‘ ?

    With this solution roster2 is now raising a javascript error in Catalan for example.

    The same is going to happen if you add some i18n string with ‘ character in any language.

    Sometime ago we solved a similar problem modifying the translation file:

https://jira.sakaiproject.org/browse/SAK-26261

    There was a “ in some translation string and we changed to \"

    I think that solution wasn’t good enough too.

 

    Maybe we must file a new jira to solve this problem in a definitive way.

 

Thanks !! 

 

 

El 17/10/2014, a las 21:23, Neal Caidin <neal.caidin at apereo.org <mailto:neal.caidin at apereo.org> > escribió:

 

As they say in the South, an expression I've never really understood, "cool beans".

 

 

On Fri, Oct 17, 2014 at 2:31 PM, Bryan Holladay <holladay at longsight.com <mailto:holladay at longsight.com> > wrote:

I only did the coding (as far as the jira is concerned). As for testing, I patched this to a production 10.x instance and it worked. It also sounds like Igor tested it.

 

On Fri, Oct 17, 2014 at 2:28 PM, Neal Caidin <neal.caidin at apereo.org <mailto:neal.caidin at apereo.org> > wrote:

Bryan,

Thank you for the quick work!

Are you doing both the coding and the testing? If so, I strongly recommend that we find others to verify, if possible. Better to separate those two roles from a quality assurance perspective.

Cheers,
Neal







 <mailto:holladay at longsight.com> Bryan Holladay

October 17, 2014 at 2:26 PM

I mentioned it earlier in the thread:  <https://jira.sakaiproject.org/browse/SAK-27991> https://jira.sakaiproject.org/browse/SAK-27991

 



 <mailto:neal.caidin at apereo.org> Neal Caidin

October 17, 2014 at 2:24 PM

Jira for this one?

Thanks,
Neal






 <mailto:holladay at longsight.com> Bryan Holladay

October 17, 2014 at 1:44 PM

+1 to get this merged into 10.x soon ;)

 

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org> 
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"



 <mailto:Igor at escience.uni-bremen.de> igor Novopashenny

October 17, 2014 at 1:42 PM

Thanks!

It works now

Regards Igor

 

Von: sakai-dev-bounces at collab.sakaiproject.org <mailto:sakai-dev-bounces at collab.sakaiproject.org>  [mailto:sakai-dev-bounces at collab.sakaiproject.org] Im Auftrag von Bryan Holladay
Gesendet: Freitag, 17. Oktober 2014 19:35
An: igor Novopashenny
Cc: Sakai Development
Betreff: Re: [Building Sakai] Sakai 10.2 Roster

 

That's the i18n issue. Look at this file:

 

webapps/sakai-roster2-tool/WEB-INF/bootstrap.jsp

To fix it, just replace (or add) this line for the "var roster = .." variable:
i18n: {
                        <c:forEach items="${i18n}" var="i" varStatus="is">
                             ${i.key}: '${i.value}'<c:if test="${!is.last}">,</c:if>
                        </c:forEach>
                } 

 

 

On Fri, Oct 17, 2014 at 1:29 PM, igor Novopashenny <Igor at escience.uni-bremen.de <mailto:Igor at escience.uni-bremen.de> > wrote:

 

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org> 
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"



 <mailto:holladay at longsight.com> Bryan Holladay

October 17, 2014 at 1:34 PM

That's the i18n issue. Look at this file:

 

webapps/sakai-roster2-tool/WEB-INF/bootstrap.jsp

To fix it, just replace (or add) this line for the "var roster = .." variable:
i18n: {
                        <c:forEach items="${i18n}" var="i" varStatus="is">
                             ${i.key}: '${i.value}'<c:if test="${!is.last}">,</c:if>
                        </c:forEach>
                } 

 

 

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org> 
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"

 

-- 
Neal Caidin
Sakai Community Coordinator
Apereo Foundation
neal.caidin at apereo.org <mailto:neal.caidin at apereo.org> 
Skype me! (but let me know in advance for the first interaction) - nealkdin

 

 

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org> 
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"

 

 

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org> 
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20141018/806d5639/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 770 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20141018/806d5639/attachment.jpe 


More information about the sakai-dev mailing list