[Building Sakai] Sakai 10.2 Roster

[Juan José Meroño Sánchez]

Hi,

    I think your solution is not good enough, what about translations that include ‘ ?
    With this solution roster2 is now raising a javascript error in Catalan for example.
    The same is going to happen if you add some i18n string with ‘ character in any language.
    Sometime ago we solved a similar problem modifying the translation file:
	https://jira.sakaiproject.org/browse/SAK-26261
    There was a “ in some translation string and we changed to \"
    I think that solution wasn’t good enough too.

    Maybe we must file a new jira to solve this problem in a definitive way.

Thanks !! 


> El 17/10/2014, a las 21:23, Neal Caidin <neal.caidin at apereo.org> escribió:
> 
> As they say in the South, an expression I've never really understood, "cool beans".
> 
> 
> On Fri, Oct 17, 2014 at 2:31 PM, Bryan Holladay <holladay at longsight.com <mailto:holladay at longsight.com>> wrote:
> I only did the coding (as far as the jira is concerned). As for testing, I patched this to a production 10.x instance and it worked. It also sounds like Igor tested it.
> 
> On Fri, Oct 17, 2014 at 2:28 PM, Neal Caidin <neal.caidin at apereo.org <mailto:neal.caidin at apereo.org>> wrote:
> Bryan,
> 
> Thank you for the quick work!
> 
> Are you doing both the coding and the testing? If so, I strongly recommend that we find others to verify, if possible. Better to separate those two roles from a quality assurance perspective.
> 
> Cheers,
> Neal
> 
> 
>> 	Bryan Holladay <mailto:holladay at longsight.com>	October 17, 2014 at 2:26 PM
>> I mentioned it earlier in the thread: https://jira.sakaiproject.org/browse/SAK-27991 <https://jira.sakaiproject.org/browse/SAK-27991>
>> 
>> 
>> 	Neal Caidin <mailto:neal.caidin at apereo.org>	October 17, 2014 at 2:24 PM
>> Jira for this one?
>> 
>> Thanks,
>> Neal
>> 
>> 
>> 
>> 	Bryan Holladay <mailto:holladay at longsight.com>	October 17, 2014 at 1:44 PM
>> +1 to get this merged into 10.x soon ;)
>> 
>> 
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org>
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev <http://collab.sakaiproject.org/mailman/listinfo/sakai-dev>
>> 
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"
>> 	igor Novopashenny <mailto:Igor at escience.uni-bremen.de>	October 17, 2014 at 1:42 PM
>> Thanks!
>> 
>> It works now
>> 
>> Regards Igor
>> 
>>  
>> 
>> Von: sakai-dev-bounces at collab.sakaiproject.org <mailto:sakai-dev-bounces at collab.sakaiproject.org> [mailto:sakai-dev-bounces at collab.sakaiproject.org <mailto:sakai-dev-bounces at collab.sakaiproject.org>] Im Auftrag von Bryan Holladay
>> Gesendet: Freitag, 17. Oktober 2014 19:35
>> An: igor Novopashenny
>> Cc: Sakai Development
>> Betreff: Re: [Building Sakai] Sakai 10.2 Roster
>> 
>>  
>> 
>> That's the i18n issue. Look at this file:
>> 
>>  
>> 
>> webapps/sakai-roster2-tool/WEB-INF/bootstrap.jsp
>> 
>> To fix it, just replace (or add) this line for the "var roster = .." variable:
>> i18n: {
>>                         <c:forEach items="${i18n}" var="i" varStatus="is">
>>                              ${i.key}: '${i.value}'<c:if test="${!is.last}">,</c:if>
>>                         </c:forEach>
>>                 }
>> 
>>  
>> 
>>  
>> 
>> On Fri, Oct 17, 2014 at 1:29 PM, igor Novopashenny <Igor at escience.uni-bremen.de <mailto:Igor at escience.uni-bremen.de>> wrote:
>> 
>>  
>> 
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org>
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev <http://collab.sakaiproject.org/mailman/listinfo/sakai-dev>
>> 
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"
>> 	Bryan Holladay <mailto:holladay at longsight.com>	October 17, 2014 at 1:34 PM
>> That's the i18n issue. Look at this file:
>> 
>> webapps/sakai-roster2-tool/WEB-INF/bootstrap.jsp
>> 
>> To fix it, just replace (or add) this line for the "var roster = .." variable:
>> i18n: {
>>                         <c:forEach items="${i18n}" var="i" varStatus="is">
>>                              ${i.key}: '${i.value}'<c:if test="${!is.last}">,</c:if>
>>                         </c:forEach>
>>                 }
>> 
>> 
>> 
>> 
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org <mailto:sakai-dev at collab.sakaiproject.org>
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev <http://collab.sakaiproject.org/mailman/listinfo/sakai-dev>
>> 
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"
> 
> -- 
> Neal Caidin
> Sakai Community Coordinator
> Apereo Foundation
> neal.caidin at apereo.org <mailto:neal.caidin at apereo.org>
> Skype me! (but let me know in advance for the first interaction) - nealkdin
> 
> 
> 
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> 
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20141017/07003cb2/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compose-unknown-contact.jpg
Type: image/jpeg
Size: 770 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20141017/07003cb2/attachment.jpg