[Building Sakai] <code> tag and the tool_base.css

[Jonas Eriksson]

Thanks Matthew!

I know about svn blame but did not think of it as an answer to my question ☺

Our modified relogin/xlogin/help rendered fine without setting the font in <code>.

Nevertheless I created a jira (SAK-27977) for this as the user may want to use <code> to format code in the editor.

Regards
Jonas

From: Matthew Jones [mailto:matthew at longsight.com]
Sent: den 10 oktober 2014 15:44
To: Jonas Eriksson
Cc: sakai-dev at collab.sakaiproject.org
Subject: Re: [Building Sakai] <code> tag and the tool_base.css

Usually you run "svn blame" on the file to try to find the answer to those questions. (Going through the blame on the UI at https://source.sakaiproject.org/websvn/ or a GUI client is sometimes faster)

  9117 gsilver at um code {
 52224 s.swinsbur               font-family: verdana, arial, helvetica, sans-serif;
  9117 gsilver at um             font-size:1em;
  9117 gsilver at um

Then run "svn log -c" on the revisions to find where the SAK made that change.

svn log -c 52224
SAK-14014 relogin page textbox styling

svn log -c 9117
http://bugs.sakaiproject.org/jira/browse/SAK-4412

SAK-4412 says it was done all the way back in 2.2 to fix rendering issue in FF in help docs back in 2006. Maybe this isn't needed anymore, or maybe it's not targeted specific enough.


On Fri, Oct 10, 2014 at 7:22 AM, Jonas Eriksson <jonas.eriksson at umu.se<mailto:jonas.eriksson at umu.se>> wrote:
Hi all,

Is there any reason why the tool_base.css (in 2.9 at least) contains the “code” class definition?

code {
                             font-family: verdana, arial, helvetica, sans-serif;
                             font-size:1em;
}

Instead of letting the user agent have its default monospaced font?

Thanks

Jonas Eriksson
Systemutvecklare
IT-stöd och systemutveckling (ITS)
Umeå universitet
901 87 Umeå
Telefon +46 90 786 70 96<tel:%2B46%2090%20786%2070%2096>
jonas.eriksson at umu.se<mailto:jonas.eriksson at umu.se>
www.its.umu.se<http://www.its.umu.se/>



_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20141013/9656e45d/attachment.html