[Building Sakai] Problems creating a new site type in Sakai 10

[Kirschner, Beth]

Hi Diego,

I'd go ahead and write up a Sakai (SAK) JIRA with the "Worksiet Setup" component -- I agree that the code below is hard-coded to disallow any additional site types.

Muchas gracias!
- Beth

On Jul 18, 2014, at 6:00 AM, Diego del Blanco Orobitg <diego.delblanco.sakai at gmail.com> wrote:

> Hi Beth!
> 
> I don't know what I did yesterday to check trunk code because I've realized today that trunk has the same code than in Sakai 10... the one that is failing.  (And it's tested today and it does not work in trunk, so Sakai 10 and trunk fail)
> 
> This is in:
> https://source.sakaiproject.org/svn/site-manage/trunk/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-type.vm
> 
> In the lines 53 to 57 (In sakai 10 code it is in lines 58 and next ones)
> 
>  #foreach ($type in $siteTypes)
> 		#set($courseTypeWithPerm    = ((($courseSiteTypeStrings.contains($type)     && $type == "course")     || $type == "course")    && $canAddCourse ))
> 		#set($portfolioTypeWithPerm = ((($portfolioSiteTypeStrings.contains($type) && $type == "portfolio")  || $type == "portfolio") && $canAddPortfolio )) 
> 		#set($projectTypeWithPerm   = ((($projectSiteTypeStrings.contains($type)   && $type == "project")    || $type == "project")   && $canAddProject )) 
> 		#if (($courseTypeWithPerm) || ($portfolioTypeWithPerm) || ($projectTypeWithPerm)) 
> 
> Maybe I'm wrong but this code seems to allow only the three default types to be shown...
> 
> Please, tell me where (in Jira) I need to write this.
> 
> Thanks and "muchos saludos!!!"
> 
> Diego
> 
> 
> 2014-07-17 22:15 GMT+02:00 Kirschner, Beth <bkirschn at umich.edu>:
> Hi Diego,
> 
> I wouldn't re-open a JIRA that was resolved in 2012 - this looks like a new bug that was fixed in trunk, but not merged to Sakai 10. I wonder if this is maybe SAK-23775 that needs to be merged? Can you provide line numbers of the code that you reference bellow?
> 
> Thanks,
> - Beth
> 
> On Jul 17, 2014, at 6:32 AM, Diego del Blanco Orobitg <diego.delblanco.sakai at gmail.com> wrote:
> 
> > I've reopened SAK-22994
> >
> >
> >
> >
> > 2014-07-17 12:24 GMT+02:00 Diego del Blanco Orobitg <diego.delblanco.sakai at gmail.com>:
> > mmmm, seems that Sakai 10.x code is not the good one... same lines in same file...
> >
> > /site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-type.vm
> >
> > In SAKAI 10.x code:
> >
> > #foreach ($type in $siteTypes)
> >       #set($courseTypeWithPerm    = ((($courseSiteTypeStrings.contains($type)     && $type == "course")     || $type == "course")    && $canAddCourse ))
> >       #set($portfolioTypeWithPerm = ((($portfolioSiteTypeStrings.contains($type) && $type == "portfolio")  || $type == "portfolio") && $canAddPortfolio ))
> >       #set($projectTypeWithPerm   = ((($projectSiteTypeStrings.contains($type)   && $type == "project")    || $type == "project")   && $canAddProject ))
> >       #if (($courseTypeWithPerm) || ($portfolioTypeWithPerm) || ($projectTypeWithPerm))
> >
> >
> >
> > In TRUNK (and in 2.9.x) code:
> >
> >  #foreach ($type in $siteTypes)
> >
> >  #if (($type == $courseSiteType && $canAddCourse) || ($type == $portfolioSiteType && $canAddPortfolio) || ($type == $projectSiteType && $canAddProject) || ($type != $courseSiteType && $type != $portfolioSiteType && $type != $projectSiteType))
> >
> >
> >
> >
> >
> >
> > 2014-07-17 12:09 GMT+02:00 Diego del Blanco Orobitg <diego.delblanco.sakai at gmail.com>:
> >
> > Hi:
> >
> > I'm trying to create a new site type in Sakai 10. I've updated the sakai.sitesetup.xml file and .... and I can't view my new site type when I try to create a site (only project and course)
> >
> > This is what I changed in that file:
> >
> >
> > <configuration name="siteTypes" value="course,project,investigacion" />
> >
> > and
> >
> > <configuration name="publicChangeableSiteTypes" value="project,investigacion" />
> >
> >
> > To test if I was touching the wrong file, I've updated the same file and added the portfolio type too:
> >
> > <configuration name="siteTypes" value="course,project,portfolio,investigacion" />
> >
> > and now I can view project, course and portfolio, but not my new type.
> >
> > So... file is the right one, this is sure becuase the portfolio change has worked...  why not with "investigation" new type????
> >
> >
> > Maybe It's something related in this JIRA, https://jira.sakaiproject.org/browse/SAK-22994 but this is supposedly solved for Sakai 2.9... and I'm trying in Sakai 10.
> >
> > Maybe a regression? Maybe I'm doing something wrong or forgotten another step?
> >
> > I've not added this filetype in the different tools.xml files, but I think this is not necessary to show the new file type when creation a new site.
> >
> > Thanks!
> > --
> > ***************************************
> > Diego del Blanco Orobitg
> > Spain & LATAM Regional Manager (ANI Sakai)
> > Apereo LATAM Representative (Apereo Foundation)
> >
> > P: (+34) 653 683 489
> > E: ddelblanco at anisakai.com
> > Sk: ddelblanco.ani
> > ***************************************
> >
> >
> >
> > --
> > ***************************************
> > Diego del Blanco Orobitg
> > Spain & LATAM Regional Manager (ANI Sakai)
> > Apereo LATAM Representative (Apereo Foundation)
> >
> > P: (+34) 653 683 489
> > E: ddelblanco at anisakai.com
> > Sk: ddelblanco.ani
> > ***************************************
> >
> >
> >
> > --
> > ***************************************
> > Diego del Blanco Orobitg
> > Spain & LATAM Regional Manager (ANI Sakai)
> > Apereo LATAM Representative (Apereo Foundation)
> >
> > P: (+34) 653 683 489
> > E: ddelblanco at anisakai.com
> > Sk: ddelblanco.ani
> > ***************************************
> > _______________________________________________
> > sakai-dev mailing list
> > sakai-dev at collab.sakaiproject.org
> > http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> >
> > TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
> 
> 
> 
> 
> -- 
> ***************************************
> Diego del Blanco Orobitg
> Spain & LATAM Regional Manager (ANI Sakai)
> Apereo LATAM Representative (Apereo Foundation)
> 
> P: (+34) 653 683 489
> E: ddelblanco at anisakai.com
> Sk: ddelblanco.ani
> ***************************************