[Building Sakai] Content quotas
John Bush
jbush at anisakai.com
Thu Sep 12 22:49:37 PDT 2013
open a bug, its an easy fix and would save someone else pain. Stuff like
this can ruin your day, trust me, I've had a lot of days ruined by stuff
like this. Open a jira, attach this patch, since my kernel commit access
has been revoked, that's the best I can offer.
Index: api/src/main/java/org/sakaiproject/util/RequestFilter.java
===================================================================
--- api/src/main/java/org/sakaiproject/util/RequestFilter.java (revision
129690)
+++ api/src/main/java/org/sakaiproject/util/RequestFilter.java (working
copy)
@@ -906,20 +906,20 @@
// is not defined.
if (System.getProperty(SYSTEM_UPLOAD_MAX) != null)
{
- m_uploadMaxSize =
Long.valueOf(System.getProperty(SYSTEM_UPLOAD_MAX)).longValue() * 1024L *
1024L;
+ m_uploadMaxSize =
Long.valueOf(System.getProperty(SYSTEM_UPLOAD_MAX).trim()).longValue() *
1024L * 1024L;
m_uploadCeiling = m_uploadMaxSize;
}
// if the maximum allowed upload size is configured on the filter, it
overrides the system property
if (filterConfig.getInitParameter(CONFIG_UPLOAD_MAX) != null)
{
- m_uploadMaxSize =
Long.valueOf(filterConfig.getInitParameter(CONFIG_UPLOAD_MAX)).longValue()
* 1024L * 1024L;
+ m_uploadMaxSize =
Long.valueOf(filterConfig.getInitParameter(CONFIG_UPLOAD_MAX).trim()).longValue()
* 1024L * 1024L;
}
// get the upload max ceiling that limits any other upload max, if defined
if (System.getProperty(SYSTEM_UPLOAD_CEILING) != null)
{
- m_uploadCeiling =
Long.valueOf(System.getProperty(SYSTEM_UPLOAD_CEILING)).longValue() * 1024L
* 1024L;
+ m_uploadCeiling =
Long.valueOf(System.getProperty(SYSTEM_UPLOAD_CEILING).trim()).longValue()
* 1024L * 1024L;
}
// get the system wide settin, if present, for the temp dir
On Thu, Sep 12, 2013 at 11:21 AM, Neal Caidin <neal.caidin at apereo.org>wrote:
> Should I open a Jira or is it just too minor?
>
> Thanks,
> Neal
>
>
>
> Neal Caidin
> Sakai CLE Community Coordinator
> neal.caidin at apereo.org
> Skype: nealkdin
> Twitter: ncaidin
>
>
>
>
>
>
>
>
>
> On Sep 12, 2013, at 2:16 PM, Matthew Jones <matthew at longsight.com> wrote:
>
> Most properties should be safe. In this case these properties are parsed
> by System.getProperty rather than ServerConfigurationService getInt and
> RequestFilter crashes. It looks like you picked one of the lucky 2
> properties that could cause a problem here.
>
> content.upload.max
> content.upload.ceiling
>
> So this is a bug, and one you just accidentally stumbled upon.
>
>
> On Thu, Sep 12, 2013 at 1:59 PM, Neal Caidin <neal.caidin at apereo.org>wrote:
>
>> Thanks!
>>
>>
>> Yep, that worked. After much gnashing of teeth because I had a trailing
>> whitespace character after the content.upload.max=50 property which caused
>> Sakai to not load properly!
>>
>>
>> urghhh. All fixed now. aaahhh.
>>
>>
>>
>> Neal Caidin
>> Sakai CLE Community Coordinator
>> neal.caidin at apereo.org
>> Skype: nealkdin
>> Twitter: ncaidin
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On Sep 9, 2013, at 4:18 PM, Kevin Takacs <ktakacs at anisakai.com> wrote:
>>
>> The content.upload.max property is used for attachments, for the
>> resources tool content.upload.ceiling needs to be adjusted.
>>
>> From default.sakai.properties in trunk:
>>
>> # Upload limit per request, in MBs.
>> # "ceiling" is used for resources. "max" is used for attachments.
>> # In the case when both are set, resources are limited to the smaller of
>> the two. If only one of the two are set, resource uploads
>> # are limited to the value whichever is set. Attachments are limited at
>> either 20 or the setting of "max".
>> # Example: content.upload.max=50 and content.upload.ceiling=25
>> (attachments limit of 50MB and resource uploads at 25MB)
>> # Example: content.upload.max=10 and content.upload.ceiling=15
>> (attachments limit of 10MB and resource uploads at 10MB)
>> # Example: content.upload.ceiling=25 (attachments limit of 20MB and
>> resource uploads at 25MB)
>> # Example: content.upload.max=50 (attachments limit of 50MB and resource
>> uploads at 50MB)
>> # DEFAULT: 20
>> # content.upload.max=20
>> # **Note - online documentation states ceiling is set in bytes - this is
>> incorrect. Settings are in MB.
>> # content.upload.ceiling=20
>>
>>
>> On Mon, Sep 9, 2013 at 1:16 PM, Geng, Kelly <gengx at miamioh.edu> wrote:
>>
>>> Assume you have this set over 20M?
>>>
>>> # upload limit per request, in megs
>>> content.upload.max=
>>>
>>> At least in 2.9-.
>>>
>>>
>>> On Mon, Sep 9, 2013 at 3:02 PM, Neal Caidin <neal.caidin at apereo.org>wrote:
>>>
>>>> Hi all,
>>>>
>>>> I'm trying to test
>>>>
>>>> https://jira.sakaiproject.org/browse/SAK-23678
>>>>
>>>> and I want to use a file greater than 20 Mb. So I am running trunk
>>>> locally and I set content.quota=61200 in my local.properties file. But I
>>>> still cannot seem to upload a file greater than 20 Mb.
>>>>
>>>> I notice
>>>> https://jira.sakaiproject.org/browse/SAK-23640
>>>> https://jira.sakaiproject.org/browse/KNL-921
>>>>
>>>> which indicates that content.quota was working, then not working, and
>>>> should be working again, but it does not appear to be working for me.
>>>>
>>>> Any thoughts?
>>>>
>>>> Confused in Durham….
>>>>
>>>>
>>>>
>>>>
>>>> Neal Caidin
>>>> Sakai CLE Community Coordinator
>>>> neal.caidin at apereo.org
>>>> Skype: nealkdin
>>>> Twitter: ncaidin
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> sakai-dev mailing list
>>>> sakai-dev at collab.sakaiproject.org
>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>
>>>> TO UNSUBSCRIBE: send email to
>>>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>>>> "unsubscribe"
>>>>
>>>
>>>
>>>
>>> --
>>> Kelly
>>>
>>> _______________________________________________
>>> sakai-dev mailing list
>>> sakai-dev at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>
>>> TO UNSUBSCRIBE: send email to
>>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>>> "unsubscribe"
>>>
>>
>>
>>
>> --
>> Kevin Takacs
>> Software Engineer
>> *O **602-337-8408*
>> *M **480-544-1972*
>>
>>
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>>
>
>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to
> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
--
John Bush
602-490-0470
** This message is neither private nor confidential in fact the US
government is storing it in a warehouse located in Utah for future data
mining use cases should they arise. **
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130912/8ea4f90a/attachment.html
More information about the sakai-dev
mailing list