[Building Sakai] nightly trunk build down with search code

Aaron Zeckoski azeckoski at unicon.net
Tue May 21 09:31:25 PDT 2013 

That searchServer one was supposed to just be set on one node so I
don't think that is what you meant to put for enabling search.

I thought it was something more like:
search.enable = true
search.experimental = true

It should be possible to leave out the key at bean=value type configs
entirely (or that should be a goal if it is not).
-AZ


On Tue, May 21, 2013 at 12:20 PM, John Bush <john.bush at rsmart.com> wrote:
> It should be no different from what you were doing in the past.  So
> get latest, and set this as you like:
>
> searchServer at org.sakaiproject.search.api.SearchService=true
>
> and it should work fine.  I verified it with both elasticsearch turned
> on and the legacy search turned on (which is the default in trunk
> now).   To switch to ES you must set the following at a minimum:
>
> search.service.impl=org.sakaiproject.search.elasticsearch.ElasticSearchService
> search.indexbuilder.impl=org.sakaiproject.search.elasticsearch.ElasticSearchIndexBuilder
>
> On Tue, May 21, 2013 at 2:07 AM, Steve Swinsburg
> <steve.swinsburg at gmail.com> wrote:
>> So what's the way to use that searchServer config now, or is it not supported at all?
>>
>> Cheers
>> Steve
>>
>> Sent from my iPhone
>>
>> On 21/05/2013, at 5:12, John Bush <john.bush at rsmart.com> wrote:
>>
>>> Yeah, the fancy thing didn't work so I went with simple thing.  It's
>>> committed. Its really only one setter that I'm aware of the is causing
>>> the issue, so yeah, super easy to just deal with it that way.
>>>
>>> On Mon, May 20, 2013 at 11:57 AM, Aaron Zeckoski <azeckoski at unicon.net> wrote:
>>>> There is no overhead for people to set those values (unless you mean
>>>> you and Colin, in which case you have to have them in your
>>>> implementations). If the blah at bean=value is not there then nothing
>>>> happens. If it is there and there is no matching setter then spring
>>>> dies. So the easy solution is just put in the setter and log a warning
>>>> and roll on.
>>>>
>>>> As Matthew correctly surmises, it is non-trivial to change the spring behavior.
>>>>
>>>> I suggest you go for the easy solution here and just toss in a few setters.
>>>> -AZ
>>>>
>>>>
>>>> On Mon, May 20, 2013 at 2:22 PM, John Bush <john.bush at rsmart.com> wrote:
>>>>> Right, that would certainly work, but adds some overhead for people to
>>>>> include those no op setters.
>>>>>
>>>>> I was thinking about trying to just use,
>>>>> http://static.springsource.org/spring/docs/2.5.x/api/org/springframework/aop/framework/ProxyFactoryBean.html,
>>>>> like we do for GroupProvider and other things, but not actually call
>>>>> out a proxyInterface.  According to the javadoc, "Set the names of the
>>>>> interfaces we're proxying. If no interface is given, a CGLIB for the
>>>>> actual class will be created." that means it would just probably
>>>>> extend your impl directly, thus exposing the setters.
>>>>>
>>>>> see https://jira.sakaiproject.org/browse/SRCH-119 for more.
>>>>>
>>>>> I'm not sure if this will cause spring to bitch in other places
>>>>> because of not exposing the interface, giving it a go now...
>>>>>
>>>>> On Mon, May 20, 2013 at 11:09 AM, Aaron Zeckoski <azeckoski at unicon.net> wrote:
>>>>>> We have dealt with this before my just having setters in the
>>>>>> implementation that log something like "this config value is not
>>>>>> supported, please remove it from your config file" or some such. This
>>>>>> is a good reason to NOT have any important values configured using the
>>>>>> blah at servicebean=value method. It actually exposes the implementation.
>>>>>>
>>>>>> -AZ
>>>>>>
>>>>>>
>>>>>> On Mon, May 20, 2013 at 1:34 PM, John Bush <john.bush at rsmart.com> wrote:
>>>>>>> ug yeah, the patch Colin provided doesn't work with those type of
>>>>>>> properties, I think this approach is going to have to be reconsidered
>>>>>>> cause its not going to be backwards compatible with the old
>>>>>>> properties.  I'll just back this out until we can come up with
>>>>>>> something that it less destructive.
>>>>>>>
>>>>>>> On Sat, May 18, 2013 at 3:10 AM, Steve Swinsburg
>>>>>>> <steve.swinsburg at gmail.com> wrote:
>>>>>>>> I've taken that property out because I dont need it on this server and now
>>>>>>>> we are running, but I believe its a documented property.
>>>>>>>>
>>>>>>>> cheers,
>>>>>>>> S
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sat, May 18, 2013 at 7:57 PM, Steve Swinsburg <steve.swinsburg at gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> I just did a fresh checkout of trunk and am still getting errors in
>>>>>>>>> search:
>>>>>>>>>
>>>>>>>>> org.springframework.beans.factory.BeanCreationException: Error creating
>>>>>>>>> bean with name 'forumsAdaptor' defined in file
>>>>>>>>> [/opt/sakai/cle/apache-tomcat-7.0.40/components/messageforums-components/WEB-INF/components.xml]:
>>>>>>>>> Cannot resolve reference to bean 'org.sakaiproject.search.api.SearchService'
>>>>>>>>> while setting bean property 'searchService'; nested exception is
>>>>>>>>> org.springframework.beans.factory.BeanCreationException: Error creating bean
>>>>>>>>> with name 'org.sakaiproject.search.api.SearchService' defined in file
>>>>>>>>> [/opt/sakai/cle/apache-tomcat-7.0.40/components/search-pack/WEB-INF/components.xml]:
>>>>>>>>> Error setting property values; nested exception is
>>>>>>>>> org.springframework.beans.NotWritablePropertyException: Invalid property
>>>>>>>>> 'searchServer' of bean class
>>>>>>>>> [org.sakaiproject.search.adapter.SearchServiceAdapter]: Bean property
>>>>>>>>> 'searchServer' is not writable or has an invalid setter method. Does the
>>>>>>>>> parameter type of the setter match the return type of the getter?
>>>>>>>>>
>>>>>>>>> My search config is:
>>>>>>>>> search.enable=true
>>>>>>>>> searchServer at org.sakaiproject.search.api.SearchService=true
>>>>>>>>>
>>>>>>>>> localIndexBase at org.sakaiproject.search.api.JournalSettings=${filestorage.base}/search/index
>>>>>>>>>
>>>>>>>>> sharedJournalBase at org.sakaiproject.search.api.JournalSettings=${filestorage.base}/search
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, May 17, 2013 at 2:49 AM, John Bush <john.bush at rsmart.com> wrote:
>>>>>>>>>>
>>>>>>>>>> should be fixed now
>>>>>>>>>>
>>>>>>>>>> On Thu, May 16, 2013 at 8:31 AM, John Bush <john.bush at rsmart.com> wrote:
>>>>>>>>>>> I'm on it
>>>>>>>>>>>
>>>>>>>>>>> On Thu, May 16, 2013 at 7:46 AM, Zhen Qian <zqian at umich.edu> wrote:
>>>>>>>>>>>> Hi, all:
>>>>>>>>>>>>
>>>>>>>>>>>> The trunk build is broken now with errors related to search. Could
>>>>>>>>>>>> someone
>>>>>>>>>>>> please take a look?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>
>>>>>>>>>>>> - Zhen
>>>>>>>>>>>>
>>>>>>>>>>>> 2013-05-16 08:13:07,533  WARN localhost-startStop-1
>>>>>>>>>>>> org.sakaiproject.component.impl.SpringCompMgr -
>>>>>>>>>>>>
>>>>>>>>>>>> get(org.sakaiproject.search.component.service.impl.ConcurrentSearchServiceImpl):
>>>>>>>>>>>> org.springframework.beans.factory.BeanCreationException: Error
>>>>>>>>>>>> creating bean
>>>>>>>>>>>> with name
>>>>>>>>>>>>
>>>>>>>>>>>> 'org.sakaiproject.search.component.service.impl.ConcurrentSearchServiceImpl'
>>>>>>>>>>>> defined in file
>>>>>>>>>>>>
>>>>>>>>>>>> [/home/tomcat-nightly/sakai-demo-oracle/components/search-pack/WEB-INF/parallelIndexComponents.xml]:
>>>>>>>>>>>> Cannot resolve reference to bean
>>>>>>>>>>>> 'org.sakaiproject.search.index.IndexStorage' while setting bean
>>>>>>>>>>>> property
>>>>>>>>>>>> 'indexStorage'; nested exception is
>>>>>>>>>>>> org.springframework.beans.factory.BeanCreationException: Error
>>>>>>>>>>>> creating bean
>>>>>>>>>>>> with name 'org.sakaiproject.search.index.IndexStorage' defined in file
>>>>>>>>>>>>
>>>>>>>>>>>> [/home/tomcat-nightly/sakai-demo-oracle/components/search-pack/WEB-INF/parallelIndexComponents.xml]:
>>>>>>>>>>>> Cannot resolve reference to bean
>>>>>>>>>>>>
>>>>>>>>>>>> 'org.sakaiproject.search.api.SearchService.parallel.index.journaledFSIndexStorage'
>>>>>>>>>>>> while setting bean property 'indexStorageProvider'; nested exception
>>>>>>>>>>>> is
>>>>>>>>>>>> org.springframework.beans.factory.BeanCreationException: Error
>>>>>>>>>>>> creating bean
>>>>>>>>>>>> with name
>>>>>>>>>>>>
>>>>>>>>>>>> 'org.sakaiproject.search.api.SearchService.parallel.index.journaledFSIndexStorage'
>>>>>>>>>>>> defined in file
>>>>>>>>>>>>
>>>>>>>>>>>> [/home/tomcat-nightly/sakai-demo-oracle/components/search-pack/WEB-INF/parallelIndexComponents.xml]:
>>>>>>>>>>>> Cannot resolve reference to bean
>>>>>>>>>>>>
>>>>>>>>>>>> 'org.sakaiproject.search.api.SearchService.parallel.index.concurrentIndexManager'
>>>>>>>>>>>> while setting bean property 'indexListener' with key [0]; nested
>>>>>>>>>>>> exception
>>>>>>>>>>>> is org.springframework.beans.factory.BeanCreationException: Error
>>>>>>>>>>>> creating
>>>>>>>>>>>> bean with name
>>>>>>>>>>>>
>>>>>>>>>>>> 'org.sakaiproject.search.api.SearchService.parallel.index.concurrentIndexManager'
>>>>>>>>>>>> defined in file
>>>>>>>>>>>>
>>>>>>>>>>>> [/home/tomcat-nightly/sakai-demo-oracle/components/search-pack/WEB-INF/parallelIndexComponents.xml]:
>>>>>>>>>>>> Cannot resolve reference to bean
>>>>>>>>>>>> 'org.sakaiproject.search.api.SearchService'
>>>>>>>>>>>> while setting bean property 'searchService'; nested exception is
>>>>>>>>>>>> org.springframework.beans.factory.BeanCurrentlyInCreationException:
>>>>>>>>>>>> Error
>>>>>>>>>>>> creating bean with name 'org.sakaiproject.search.api.SearchService':
>>>>>>>>>>>> Requested bean is currently in creation: Is there an unresolvable
>>>>>>>>>>>> circular
>>>>>>>>>>>> reference?
>>>>>>>>>>>>      at
>>>>>>>>>>>>
>>>>>>>>>>>> org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:275)
>>>>>>>>>>>>      at
>>>>>>>>>>>>
>>>>>>>>>>>> org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:104)
>>>>>>>>>>>>      at
>>>>>>>>>>>>
>>>>>>>>>>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1245)
>>>>>>>>>>>>      at
>>>>>>>>>>>>
>>>>>>>>>>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1010)
>>>>>>>>>>>>      at
>>>>>>>>>>>>
>>>>>>>>>>>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:472)
>>>>>>>>>>>>
>>>>>>>>>>>> ...
>>>>>>>>>>>>
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> sakai-dev mailing list
>>>>>>>>>>>> sakai-dev at collab.sakaiproject.org
>>>>>>>>>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>>>>>>>>>
>>>>>>>>>>>> TO UNSUBSCRIBE: send email to
>>>>>>>>>>>> sakai-dev-unsubscribe at collab.sakaiproject.org
>>>>>>>>>>>> with a subject of "unsubscribe"
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> John Bush
>>>>>>>>>>> 602-490-0470
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> John Bush
>>>>>>>>>> 602-490-0470
>>>>>>>>>> _______________________________________________
>>>>>>>>>> sakai-dev mailing list
>>>>>>>>>> sakai-dev at collab.sakaiproject.org
>>>>>>>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>>>>>>>
>>>>>>>>>> TO UNSUBSCRIBE: send email to
>>>>>>>>>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>>>>>>>>>> "unsubscribe"
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> John Bush
>>>>>>> 602-490-0470
>>>>>>> _______________________________________________
>>>>>>> sakai-dev mailing list
>>>>>>> sakai-dev at collab.sakaiproject.org
>>>>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>>>>
>>>>>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> John Bush
>>>>> 602-490-0470
>>>>
>>>>
>>>>
>>>> --
>>>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>>>
>>>
>>>
>>> --
>>> John Bush
>>> 602-490-0470
>
>
>
> --
> John Bush
> 602-490-0470



-- 
Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile

More information about the sakai-dev mailing list