[Building Sakai] SkinnableLogin.java

[Sanghyun Jeon]

Please discard my previous email.
I found the file location ...

I will try it out and let you know the result.
Thank you again.

S

On Fri, Mar 22, 2013 at 6:11 PM, Sanghyun Jeon <euksa99 at gmail.com> wrote:

> Thank you for your reply. I am glad to hear your suggestion, but I don't
> quite understand what you mean...
>
>
> 1) copying the old LoginTool.java
> and then I assume you suggest to swap
> org.sakaiproject.login.tool.SkinnableLogin with
> org.sakaiproject.login.tool.LoginTool, but where do you recommend me to do
> this.. web.xml
> you said,  is that /reference/library/src/webapp/WEB-INF/web.xml? but I
> fail to find "org.sakaiproject.login.tool.SkinnableLogin". what about
> pasting it since I copy lod LoginTool.java?
>
>  Please educate me so that I can learn from your case.
>
> Thank you.
>
> S
>
> On Thu, Mar 21, 2013 at 3:42 PM, Adams, David <da1 at vt.edu> wrote:
>
>> Virginia Tech solved this by just copying in the old LoginTool.java file
>> and swapping out the reference in web.xml to
>> org.sakaiproject.login.tool.SkinnableLogin to
>> org.sakaiproject.login.tool.LoginTool instead. That'd be my recommended
>> path if you want to keep your customizations.
>>
>> -dave
>> ________________________________________
>> From: sakai-dev-bounces at collab.sakaiproject.org [
>> sakai-dev-bounces at collab.sakaiproject.org] On Behalf Of Sanghyun Jeon [
>> euksa99 at gmail.com]
>> Sent: Thursday, March 21, 2013 1:26 PM
>> To: John Bush
>> Cc: sakai-dev
>> Subject: Re: [Building Sakai] SkinnableLogin.java
>>
>> Our Sakai is used by 7 different schools. On the login page, we have the
>> dropdown for each school, which dictates the LDAP instance each school is
>> authenticating against. We are having trouble moving all HTML changes and
>> others in LoginTool.java into SkinnableLogin.java....Surely it is not easy
>> as we thought.
>>
>> S
>>
>>
>>
>> We have some changes on HTML part of LoginTool.java as well as some
>> others and it is
>>
>> On Wed, Mar 20, 2013 at 7:20 PM, John Bush <john.bush at rsmart.com<mailto:
>> john.bush at rsmart.com>> wrote:
>> We were bit by the same thing.  My understanding is the SkinnableLogin
>> is there to replace the long standing issue that the old LoginTool had
>> the markup hardcoded in the java code, the SkinnableLogin moves this
>> out into a template.  I think the LoginTool is no longer going to be
>> used.  It would be much better moving forward when changes like this
>> are done that we'd simply extend the existing class with the new
>> version and override the behavior we wish to change, as that sort of
>> approach has much less of a chance of causing folks that have changes
>> pain.  But then again maybe its own fault for having our own local
>> mods.
>>
>> In any event it should be a pretty simply event to move whatever you
>> have forward.
>>
>> On Wed, Mar 20, 2013 at 3:49 PM, Sanghyun Jeon <euksa99 at gmail.com<mailto:
>> euksa99 at gmail.com>> wrote:
>> > Hello All,
>> >
>> > We plan to move Sakai 2.7.0 to Sakai 2.8.x and
>> > I find one new file,  SkinnableLogin.java under
>> > login/login-tool/tool/src/java/org/sakaiproject/login/tool in Sakai
>> 2.8.x
>> >
>> > Our 2.7.0 login page is called by LoginTool.java, which has some our
>> local
>> > changes.
>> > However, when we try to move into Sakai 2.8.x, I notice that
>> > SkinnableLogin.java is consistently called, regardless login, xlogin....
>> >
>> > I am wondering what the difference between two files is and
>> LoginTool.java
>> > will be no longer used in Sakai 2.8.x.
>> >
>> > Thank you in advance.
>> >
>> > Sanghyun
>> >
>> >
>> >
>> > _______________________________________________
>> > sakai-dev mailing list
>> > sakai-dev at collab.sakaiproject.org<mailto:
>> sakai-dev at collab.sakaiproject.org>
>> > http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>> >
>> > TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:
>> sakai-dev-unsubscribe at collab.sakaiproject.org>
>> > with a subject of "unsubscribe"
>>
>>
>>
>> --
>> John Bush
>> 602-490-0470<tel:602-490-0470>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130322/cb0486bd/attachment.html