[Building Sakai] Samigo - SAM-902 (LaTEX at Numericanswerquestions) not properly fixed

[Daniel Merino]

Hi, Karen.

I have uploaded at https://jira.sakaiproject.org/browse/SAM-2015 a 
little patch for trunk that fixes this issue in Numerical Answer 
questions, replacing all braces occurrences inside IMG Tags by their 
HTML codes.

Please, could you take a look on it? I don't know Samigo code too much, 
if you think that code can be improved in some way, I'm open to suggestions.

Thanks.
Best regards.

Daniel Merino escribió:
> Hi, Karen.
>
> I have filled a new JIRA with this issue: 
> https://jira.sakaiproject.org/browse/SAM-2015
>
> As I say in that JIRA, replacing brackets for their ANSI codes ("{" by 
> %7B and "}" by %7D) solves the issue, I think that adding this to your 
> parsing methods would not be a big deal.
>
> We have not had too many issues with LaTEX use until now.
>
> Thanks in advance.
> Best regards.
>
> Karen Tsao escribió:
>   
>> Hi Daniel,
>>
>> I think the fix in SAM-902 cannot fix your issue. That is to fix 
>> brackets inside HTML img tag issue. LaTEX formulas can be quite 
>> complex. Please log a new JIRA for your issue.
>>
>> Thanks,
>> Karen
>>
>> On Wed, Nov 14, 2012 at 2:52 AM, Daniel Merino 
>> <daniel.merino at unavarra.es <mailto:daniel.merino at unavarra.es>> wrote:
>>
>>     Good morning.
>>
>>     We have received some feedback about LaTEX formulas that don't work in
>>     Numeric Answers questions in Samigo. I.e. the next html code doesn't
>>     work when creating a question:
>>
>>     Calcula&nbsp;<img align="absmiddle"
>>     alt="P\left(\frac{\bar{X}-\mu}{\sigma/\sqrt{n}} &lt; 0.12\right)"
>>     src="http://latex.codecogs.com/gif.latex?P%5Cleft(%5Cfrac{%5Cbar{X}-%5Cmu}{%5Csigma/%5Csqrt{n}}&amp;space;&lt;&amp;space;0.12%5Cright)
>>     <http://latex.codecogs.com/gif.latex?P%5Cleft%28%5Cfrac%7B%5Cbar%7BX%7D-%5Cmu%7D%7B%5Csigma/%5Csqrt%7Bn%7D%7D&amp;space;&lt;&amp;space;0.12%5Cright%29>"
>>     /> = {0.52}<br />
>>
>>     Looking at SAM-902 ( https://jira.sakaiproject.org/browse/SAM-902 ) I
>>     can see that this has been fixed for 2.8 and a new method
>>     getFIBFINanswers() has been added to ItemAddListener.java, to parse
>>     brackets in HTML, so they are not parsed as the answer brackets.
>>
>>     However, after applying the patch, I receive the same error message.
>>     Looking in the code, it seems that before parsing brackets, method
>>     isErrorFIN() is called also in ItemAddListener and it just checks the
>>     brackets opening and closening, so two opened brackets in a row cause
>>     the issue, no matter if the total count of opened an closed brackets
>>     matches.
>>
>>     I tell you this at sakai-dev instead of putting a comment in the JIRA
>>     because I don't know if this method has been fixed in any other
>>     JIRA. If
>>     it is, please could you tell me where is it? If not, I can write a
>>     comment at SAM-902 about this.
>>
>>     Thanks and best regards.
>>     --
>>     Daniel Merino Echeverría
>>     daniel.merino at unavarra.es <mailto:daniel.merino at unavarra.es>
>>     Gestor de teleformación - Centro Superior de Innovación Educativa.
>>     Tfno: 948-168489 - Universidad Pública de Navarra.
>>     _______________________________________________
>>     sakai-dev mailing list
>>     sakai-dev at collab.sakaiproject.org
>>     <mailto:sakai-dev at collab.sakaiproject.org>
>>     http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>>     TO UNSUBSCRIBE: send email to
>>     sakai-dev-unsubscribe at collab.sakaiproject.org
>>     <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
>>     subject of "unsubscribe"
>>
>>
>>     
>
>   

-- 
Daniel Merino Echeverría
daniel.merino at unavarra.es
Gestor de teleformación - Centro Superior de Innovación Educativa.
Tfno: 948-168489 - Universidad Pública de Navarra.
--
Antes yo era un poco prepotente. Ahora no, ahora soy perfecto. (Anónimo)