[Building Sakai] Problem with Height in tools with Wicket 1.5

[David Torres]

Hi!

First, I changed the subject because we are moving to other topic.

I located the line that does what you said, Steve, it is this:
response.renderOnLoadJavascript("setMainFrameHeight( window.name )");

in Wicket 1.5 is almost the same (note the capital S in JavaScript):
response.renderOnLoadJavaScript("setMainFrameHeight( window.name )");

the problem is that in Wicket 1.4 (which works fine) is generating this:
<script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
Wicket.Event.add(window, "load", function(event) { setMainFrameHeight( window.name );});
/*-->]]>*/</script>

and in Wicket 1.5 (where is not working) is generating this:
<script type="text/javascript" >
/*<![CDATA[*/
Wicket.Event.add(window, "load", function(event) { setMainFrameHeight( window.name );});
/*]]>*/
</script>

Any idea about how to solve this?
Thank you in advance


David Torres



Computer Scientist

Renuda UK



tel: +44 (0)20 3371 1709

web: www.renuda.com<http://www.renuda.com/>



Renuda UK is registered in England and Wales.  Company number 6218863.

VAT registration number 918 6490 91. Registered office: 35 Charleville Road, London W14 9JJ, UK.

________________________________
From: Steve Swinsburg [steve.swinsburg at gmail.com]
Sent: 26 February 2013 22:03
To: David Torres
Cc: Neal Caidin; sakai-dev
Subject: Re: [Building Sakai] Wicket 1.5+ in Sakai?

You probably just need to call the javascript setMainPageHeight (or whatever the function is called). check the pages in Profile2, they do that.

cheers,
Steve


On Wed, Feb 27, 2013 at 2:59 AM, David Torres <david.torres at renuda.com<mailto:david.torres at renuda.com>> wrote:
My pleasure,

unfortunately, I already found my first problem. with 1.4, the tool filled all the heigh of the page, now it is only 156 pixels of height. Please see the attached screenshot. Notice the firebug console: clientHeight = 156. I checked with Wicket 1.4 and it is clientHeight = 634

Any idea about this? Something to do with not retrieve well the skin in BasePage.java?


Best regards,


David Torres



Computer Scientist

Renuda UK



tel: +44 (0)20 3371 1709<tel:%2B44%20%280%2920%203371%201709>

web: www.renuda.com<http://www.renuda.com/>



Renuda UK is registered in England and Wales.  Company number 6218863.

VAT registration number 918 6490 91. Registered office: 35 Charleville Road, London W14 9JJ, UK.

________________________________

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130227/a2f03710/attachment.html