[Building Sakai] OSP matrix export broke in trunk

[Sobieralski, Damian Michael]

I've been trying to share back several of my institutions local fixes to osp over the past few months. I almost done!  But one thing that is a problem is that I have a fix for an osp matrix export issue. So I need exporting to work so I can verify my merge works. But in trunk, clicking on "export" before I do anything gives a NPE. After some tracing through the code the problem is that in FileDownloadServlet the parameters are only coming in w/ ONE parameter. In this case, the good old 1=1 parameter. It never is able to pull the "manager" one.

The NPE is being thrown because every parameter after 1=1 is not coming into the servlet. When I look in my browser at the link the URL has all the parameters it needs. Yet in FileDownloadServlet only the first parameter comes into it.

I notice that the servlet pattern is mapped in the web.xml:

<servlet>
      <servlet-name>repository</servlet-name>
      <servlet-class>org.sakaiproject.metaobj.shared.control.servlet.FileDownloadServlet</servlet-class>
      <load-on-startup>2</load-on-startup>
   </servlet>

   <servlet-mapping>
      <servlet-name>repository</servlet-name>
      <url-pattern>/repository/*</url-pattern>
   </servlet-mapping>


Yet the URI in FileSownoadServlet comes in as repository.osp. And then only one parameter.  I suspect whatever is re-mapping this to repository.osp might be the place that isn't carrying along the rest of the parameters. But that's just a guess.

Does anyone have any ideas here?  I've been stumped on this for days.  I'm not sure where to even put debug points to trace this. It seems to work fine in the osp 2.9 tags.  Is it possible the trunk Spring upgrade affected this?

- Damian