[Building Sakai] Sakai 2.9.2/JLDAP Issue

Tue Aug 6 13:34:14 PDT 2013

No harm at all.  I just double checked the file and it does appear the patch applied correct.  I've attached the source file, if you wouldn't mind taking a look for me.

From: Niebel, William (wdn5e) [mailto:wdn5e at eservices.virginia.edu]
Sent: Tuesday, August 06, 2013 4:16 PM
To: McCarty, Matthew C; Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org
Subject: RE: [Building Sakai] Sakai 2.9.2/JLDAP Issue

The behavior logged would be explained by
JLDAPDirectoryProvider.java(lines 665-6 below) returning ue == null and then using it as a parm.
    UserEdit ue = usersToSearchInLDAP.get(ldapEid);
    mapUserDataOntoUserEdit(ldapUserData, ue);

This would feed the null parm into JLDAPDirectoryProvider.java method mapUserDataOntoUserEdit(LdapUserData userData, UserEdit userEdit)
and then into SimpleLdapAttributeMapper.java method mapUserDataOntoUserEdit(LdapUserData userData, UserEdit userEdit)

That method calls userEdit object methods that would throw NPE resulting in the log entries.

This looks the same as SAK-23689.  Exactly .  And the log would be as you sent.

Matthew, are you sure the SAK-23689 patch applied ok, and that you rebuilt and restarted before testing again after patching?
(Forgive me and then there's no harm in asking.)

I'd be willing to look at the patched source if that would help.

________________________________
From: McCarty, Matthew C [McCartM2 at mail.amc.edu]
Sent: Tuesday, August 06, 2013 2:30 PM
To: Niebel, William (wdn5e); Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: RE: [Building Sakai] Sakai 2.9.2/JLDAP Issue
Hi, sorry for the delayed response.  It looks like we are using the SimpleLdapAttributeMapper.

Matthew McCarty
Manager, Information Services - Academic Systems
Albany Medical Center
43 New Scotland Ave.
Albany, NY 12208

desk: 518.262.0280
cell: 518.312.0706

From: Niebel, William (wdn5e) [mailto:wdn5e at eservices.virginia.edu]<mailto:[mailto:wdn5e at eservices.virginia.edu]>
Sent: Tuesday, August 06, 2013 1:28 PM
To: McCarty, Matthew C; Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: RE: [Building Sakai] Sakai 2.9.2/JLDAP Issue

Sorry to have forgotten the patch earlier.  Here it is.
________________________________
From: sakai-dev-bounces at collab.sakaiproject.org<mailto:sakai-dev-bounces at collab.sakaiproject.org> [sakai-dev-bounces at collab.sakaiproject.org] on behalf of Niebel, William (wdn5e) [wdn5e at eservices.virginia.edu]
Sent: Tuesday, August 06, 2013 12:14 PM
To: McCarty, Matthew C; Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: Re: [Building Sakai] Sakai 2.9.2/JLDAP Issue
Since from the log trace it's a RuntimeException, looking at the source at 2.9.2 JLDAPDirectoryProvider.java:700, in method getUsers(),
it was an Exception thrown, not an LDAPException.  That suggests that it may be a coding error, like NPE, and not the sakai logic explicitly throwing an LDAPException.

Following back in the log to
2013-08-06 09:48:24,212 DEBUG http-bio-8080-exec-8 edu.amc.sakai.user.JLDAPDirectoryProvider - mapUserDataOntoUserEdit() [cache record = . . .   eid=Zinskid
, that's from line 1113 in mapUserDataOntoUserEdit() of the same source file.
The next code line there is 1118 and reads
ldapAttributeMapper.mapUserDataOntoUserEdit(userData, userEdit);

The exception then is probably from your ldapAttributeMapper implementation,
in its mapUserDataOntoUserEdit() method.

At University of Virginia, we use the EntryAttributeToUserTypeMapper.java implementation
and have a local patch to that code to force our user type mapping to use lowercase user id.
(Because, like you, we have mixed case user id issues to deal with.)

That doesn't sound like it's exactly what's going on for you, but suggestively close.

I'll attach that patch as-is as we applied to for our 2.9.1 but I don't have time right now to adapt it to the sakai distribution 2.9.1 or 2.9.2 source.
(It may have been later in our patching, after some other local patches, and so not match the distribution.  I'm guessing the java code is a close match, but the configuration code further astray.)

If you tell us which AttributeToUserTypeMapper implementation you're using, I may be able to tell something from that code.
________________________________
From: McCarty, Matthew C [McCartM2 at mail.amc.edu]
Sent: Tuesday, August 06, 2013 11:46 AM
To: Niebel, William (wdn5e); Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: RE: [Building Sakai] Sakai 2.9.2/JLDAP Issue
Nope, this is set to false.

From: Niebel, William (wdn5e) [mailto:wdn5e at eservices.virginia.edu]<mailto:[mailto:wdn5e at eservices.virginia.edu]>
Sent: Tuesday, August 06, 2013 11:36 AM
To: McCarty, Matthew C; Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: RE: [Building Sakai] Sakai 2.9.2/JLDAP Issue

I would make certain that sakai property caseSensitiveCacheKeys isn't inadvertently set to true in your 2.9.2 test instance.  (I doubt that's it, but it's very much worth looking.)
________________________________
From: sakai-dev-bounces at collab.sakaiproject.org<mailto:sakai-dev-bounces at collab.sakaiproject.org> [sakai-dev-bounces at collab.sakaiproject.org] on behalf of McCarty, Matthew C [McCartM2 at mail.amc.edu]
Sent: Tuesday, August 06, 2013 11:33 AM
To: Sam Ottenhoff
Cc: sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: Re: [Building Sakai] Sakai 2.9.2/JLDAP Issue
Bear with me, as I'm a newbie to the backend of Sakai. It looks like the JLDAPDirectoryProvider file.

From: Sam Ottenhoff [mailto:ottenhoff at longsight.com]<mailto:[mailto:ottenhoff at longsight.com]>
Sent: Tuesday, August 06, 2013 10:57 AM
To: McCarty, Matthew C
Cc: Steve Swinsburg; sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
Subject: Re: [Building Sakai] Sakai 2.9.2/JLDAP Issue

And what code does that correspond to in your custom JLDAP source?

On Tue, Aug 6, 2013 at 10:56 AM, McCarty, Matthew C <McCartM2 at mail.amc.edu<mailto:McCartM2 at mail.amc.edu>> wrote:
I do, it's the same as before.  RuntimeException during search eid =username

From: Sam Ottenhoff [mailto:ottenhoff at longsight.com<mailto:ottenhoff at longsight.com>]
Sent: Tuesday, August 06, 2013 10:37 AM
To: McCarty, Matthew C
Cc: Steve Swinsburg; sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>

Subject: Re: [Building Sakai] Sakai 2.9.2/JLDAP Issue

Sam, I tried to merge those patches in, and it did not solve my issue.

Okay, do you still get a stacktrace in your catalina.out after restarting and testing again?  What code does the stacktrace correspond to?
________________________________

CONFIDENTIALITY NOTICE: This email and any attachments may contain confidential information that is protected by law and is for the sole use of the individuals or entities to which it is addressed. If you are not the intended recipient, please notify the sender by replying to this email and destroying all copies of the communication and attachments. Further use, disclosure, copying, distribution of, or reliance upon the contents of this email and attachments is strictly prohibited. To contact Albany Medical Center, or for a copy of our privacy practices, please visit us on the Internet at www.amc.edu<http://www.amc.edu>.

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments may contain confidential information that is protected by law and is for the sole use of the individuals or entities to which it is addressed. If you are not the intended recipient, please notify the sender by replying to this email and destroying all copies of the communication and attachments. Further use, disclosure, copying, distribution of, or reliance upon the contents of this email and attachments is strictly prohibited. To contact Albany Medical Center, or for a copy of our privacy practices, please visit us on the Internet at www.amc.edu<http://www.amc.edu>.

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments may contain confidential information that is protected by law and is for the sole use of the individuals or entities to which it is addressed. If you are not the intended recipient, please notify the sender by replying to this email and destroying all copies of the communication and attachments. Further use, disclosure, copying, distribution of, or reliance upon the contents of this email and attachments is strictly prohibited. To contact Albany Medical Center, or for a copy of our privacy practices, please visit us on the Internet at www.amc.edu<http://www.amc.edu>.

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments may contain confidential information that is protected by law and is for the sole use of the individuals or entities to which it is addressed. If you are not the intended recipient, please notify the sender by replying to this email and destroying all copies of the communication and attachments. Further use, disclosure, copying, distribution of, or reliance upon the contents of this email and attachments is strictly prohibited. To contact Albany Medical Center, or for a copy of our privacy practices, please visit us on the Internet at www.amc.edu<http://www.amc.edu>.

-----------------------------------------
CONFIDENTIALITY NOTICE: This email and any attachments may contain
confidential information that is protected by law and is for the
sole use of the individuals or entities to which it is addressed.
If you are not the intended recipient, please notify the sender by
replying to this email and destroying all copies of the
communication and attachments. Further use, disclosure, copying,
distribution of, or reliance upon the contents of this email and
attachments is strictly prohibited. To contact Albany Medical
Center, or for a copy of our privacy practices, please visit us on
the Internet at www.amc.edu.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130806/b2070e6b/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JLDAPDirectoryProvider.java
Type: application/octet-stream
Size: 56069 bytes
Desc: JLDAPDirectoryProvider.java
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130806/b2070e6b/attachment.obj 