[Building Sakai] i18n fixes review request

[Daniel Merino]

Hi everybody.

I have fixed these patches in three JIRAS and have uploaded them again. 
The three JIRAs are:

Announcements - https://jira.sakaiproject.org/browse/SAK-21759
Sections - https://jira.sakaiproject.org/browse/SAK-22825
Roster - https://jira.sakaiproject.org/browse/SAK-21769

In the other two JIRAs (Gradebook and Assignments) code has been fixed 
by Zhen Qian in two new tickets:

Gradebook - https://jira.sakaiproject.org/browse/SAK-21743 --> 
https://jira.sakaiproject.org/browse/SAK-23385
Assignments - https://jira.sakaiproject.org/browse/SAK-21767 --> 
https://jira.sakaiproject.org/browse/SAK-23380

Please, could somebody take a look and confirm that now the high CPU 
usage issue is solved?

Thanks in advance.
Best regards.

El 19/04/2013 11:40, daniel.merino at unavarra.es escribió:
> Hi,
>
> These incorrect patches are mine. If nobody does before, I will modify
> them but I will do that next week, as I'm not at work today.
>
> Best regards.
>
> El Vie, 19 de Abril de 2013, 11:27, Jean-Francois Leveque escribió:
>> Hi,
>>
>> David Haines rencently commented in
>> https://jira.sakaiproject.org/browse/SAK-21759:
>>> The approach used here allocates the collator in the compare method and
>>> that leads to unnecessarily high CPU usage when lots of data is
>>> involved. The allocation of the collator should be outside of the
>>> method. The implementation used in STAT-311 looks appropriate.
>> Could someone confirm the fix in
>> https://jira.sakaiproject.org/browse/STAT-311 is OK?
>>
>> If it's confirmed it's OK, could someone improve the fix for SAK-21759
>> with an implementation similar to STAT-311?
>>
>> Cheers,
>>
>> J-F
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to
>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>> "unsubscribe"
>>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>

-- 
Daniel Merino Echeverría
daniel.merino at unavarra.es
Gestor de teleformación - Centro Superior de Innovación Educativa.
Tfno: 948-168489 - Universidad Pública de Navarra.
--
Se dan buenos consejos cuando la edad impide dar malos ejemplos. 
(Excelsior)