[Building Sakai] sprited portal

[Poindexter, David Ray]

I'm new, granted, but this is an excellent move forward for the codebase. Can we not ask that a burden of proof be required for a revert? Or are we going the other direction on that?

Cheers,
--
David Poindexter
Systems Analyst
Enterprise Student Systems
UITS
Indiana University
535 West Michigan Street
Indianapolis, IN 46202-5157
O: 317.274.8686
W: http://uits.iu.edu<http://uits.iu.edu/>

From: Matthew Jones <matthew at longsight.com<mailto:matthew at longsight.com>>
Date: Thursday, April 11, 2013 12:45 PM
To: Steve Swinsburg <steve.swinsburg at gmail.com<mailto:steve.swinsburg at gmail.com>>
Cc: Sakai Dev <sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>>
Subject: Re: [Building Sakai] sprited portal

Anything committed to trunk doesn't need explicit TCC approval. The TCC can provide advice or direction but doesn't need to be consulted on every issue.

This came up last month on the dev list. http://collab.sakaiproject.org/pipermail/sakai-dev/2013-February/021176.html and it looks like Gonzalo decided to try it out. It's possible that the negatives of this change mentioned may outweigh the positives so it would be worth reverting. There shouldn't be anything wrong with reverting any change that doesn't improve the code.


On Thu, Apr 11, 2013 at 1:01 AM, Steve Swinsburg <steve.swinsburg at gmail.com<mailto:steve.swinsburg at gmail.com>> wrote:
I'm a bit concerned about local skins and needing to change the icons. Right now its a simple matter of dropping in a new icon and adjusting the CSS. With this sprite change, you'd either need to change the sprite or change the CSS to refer to a standalone image, thus adding back in the HTTP requests.

And browsers cache the images anyway, so wouldn't the HTTP requests be eliminated anyway (except for first page load)? Maybe we should put in more aggressive cache settings if that is an issue.

Also, did this change go through the TCC? IMO this is a fairly major change that impacts everyone with a custom skin.




On Thu, Apr 11, 2013 at 7:43 AM, Matthew Jones <matthew at longsight.com<mailto:matthew at longsight.com>> wrote:
Yea this is a nice effort but, but I'm not too sure reducing these http requests will really reduce overall http requests? I'm sure we'll be able to write something else to utilize those freed up http requests!

Just the same way as being more energy efficient doesn't reduce overall energy consumption. ;) Just lets us get more cooler and bigger gadgets!


On Wed, Apr 10, 2013 at 5:37 PM, Sam Ottenhoff <ottenhoff at longsight.com<mailto:ottenhoff at longsight.com>> wrote:
Super cool.  You may have just saved the world a few billion HTTP requests over the next few years!



On Wed, Apr 10, 2013 at 2:32 PM, Gonzalo Silverio <gsilver at umich.edu<mailto:gsilver at umich.edu>> wrote:
Following suggestions I have made all the portal icons into one sprite for all skins (SAK-23463<https://jira.sakaiproject.org/browse/SAK-23463>).  Still a bit more to do.

I just though I would let people know - if you notice weirdnesses clear your cache.

Thanks.

- Gonzalo

_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"


_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"


_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org<mailto:sakai-dev at collab.sakaiproject.org>
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org<mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a subject of "unsubscribe"


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20130412/58911c62/attachment.html