[Building Sakai] Please review / Comment: SAK-22633 - Fix the PDA auto-detect code to be be more selective

[Charles Severance]

Steve - I don't think we should pull all of portal back - there are only 10 or so changes since the big "portal pull" and some are already in 2-9-x and the xsl-portal is in trunk and we don't want that in 2.9 - I don't think - not because it is bad - just because we are so close to a release candidate and need to limit the scope of changes..

So I think that we need to pull only the portal mods back one by one.

/Chuck

On Sep 18, 2012, at 11:42 PM, Steve Swinsburg wrote:

> Hi Chuck
> I can test this out, I have some other portal issues to verify too. 
> 
> Cheers
> Steve
> 
> Sent from my iPhone
> 
> On 19/09/2012, at 4:11, Charles Severance <csev at umich.edu> wrote:
> 
>> Hi all, 
>> 
>> https://jira.sakaiproject.org/browse/SAK-22633
>> 
>> Describes a bug that has been many years in the making and was only detected recently by the awesome QA of Sakai 2.9.  I have a long narrative in the JIRA.   I think the bug is simple and the fix is simple - but I just want a few more eyes on the problem.
>> 
>> I am finishing testing of a fix and will add a patch to the JIRA soon and frankly I will likely just check it into trunk once I am done testing.
>> 
>> I am 99% sure I am right - but I want more eyes on the issue since a lot of folks have been through and touched this code over the year (David H, Steve S, Gonzalo S, Ian B, and me).  This is some old-school code.
>> 
>> /Chuck
>> 
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>> 
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"