[Building Sakai] SiteService.getSiteSkin and neoportal

[Adrian Fish]

When setSiteSkin is called it returns null if a skin has not been
explicitly set on a site. Is this the expected behaviour? Shouldn't it
return the name of the default skin as set by the skin.default property?
Shouldn't it also prefix the skin with 'neo-' if 'portal.templates=neoskin'
is set?

The reason I'm asking is that I've always depended on getSiteSkin returning
the actual skin name that is in use; now I've stopped explicitly specifying
skins on sites, tools like YAFT, CLOG and ROSTER2 don't get styled. It
seems odd having to implement logic in a tool to massage the skin
appropriately when it could happen in getSiteSkin. SiteStats also
implements some logic to sort the skin name out.

I've attached a patch which mods BaseSiteService in the way I describe.

Cheers,
Adrian.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20120904/a0f12f8c/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: basesiteservice.patch
Type: application/octet-stream
Size: 1878 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20120904/a0f12f8c/attachment.obj