[Building Sakai] [Using Sakai] site creation authorizer email logic

[Matthew Jones]

Oh I see, the issue back on SAK-1575 is that there wasn't an instructor to
send to on future terms. Would have probably been better to check if there
was an instructors valid email, or an instructor existed. It looks like
recent work in this area from like SAK-20801 might have made this check
completely worthless though.

On Thu, Oct 25, 2012 at 10:36 PM, John Bush <john.bush at rsmart.com> wrote:

> oh wait, I didn't look above this code I think this property will fix my
> issue:
>
> roster.available.weeks.before.term.start
>
> The problem we are having is not because the terms have ended but they
> haven't started that will do it.
>
> On Thu, Oct 25, 2012 at 7:29 PM, Matthew Jones <matthew at longsight.com>
> wrote:
> > That line was added a long time ago (2006) in SAK-1575 revision 786. So
> I'm
> > guessing you won't get your answer . . . It certainly was before the
> > IS_CURRENT logic was added course course_management.  :)
> >
> > I don't see the real point for it either, I don't' even know what the
> else
> > case would be, maybe Zhen remembers. Unless maybe if the term was already
> > past then your support staff didn't even care to be notified since these
> > courses didn't matter.
> >
> > Minimally a property like sitemanage.notify.pastlterms and just set it to
> > false. :)
> >
> > On Thu, Oct 25, 2012 at 7:56 PM, John Bush <john.bush at rsmart.com> wrote:
> >>
> >> SiteAction only sends the authorizer email when the term is current.
> >> Functionally, can someone explain this, why don't we want to notify
> >> people if the term is in the future?
> >>
> >>                         if (!isFutureTerm) {
> >>                                 for (Iterator iInstructors =
> >> authorizerList.iterator();
> >> iInstructors.hasNext();)
> >>                                 {
> >>                                         String instructorId = (String)
> >> iInstructors.next();
> >>                                         if (requireAuthorizer)
> >>                                         {
> >>                                                 // 1. email to course
> site
> >> authorizer
> >>                                                 boolean result =
> >> userNotificationProvider.notifyCourseRequestAuthorizer(instructorId,
> >> requestEmail, term != null? term.getTitle():"", requestSectionInfo,
> >> title, id, additional, productionSiteName);
> >>                                                 if (!result)
> >>                                                 {
> >>                                                         // append
> >> authorizer who doesn't received an notification
> >>
> >> authorizerNotNotified += instructorId + ", ";
> >>                                                 }
> >>                                                 else
> >>                                                 {
> >>                                                         // append
> >> authorizer who does received an notification
> >>
> authorizerNotified
> >> += instructorId + ", ";
> >>                                                 }
> >>
> >>                                         }
> >>                                 }
> >>                         }
> >>
> >> --
> >> John Bush
> >> 602-490-0470
> >>
> >> _______________________________________________
> >> sakai-user mailing list
> >> sakai-user at collab.sakaiproject.org
> >> http://collab.sakaiproject.org/mailman/listinfo/sakai-user
> >>
> >> TO UNSUBSCRIBE: send email to
> >> sakai-user-unsubscribe at collab.sakaiproject.org with a subject of
> >> "unsubscribe"
> >
> >
>
>
>
> --
> John Bush
> 602-490-0470
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20121025/01cac04b/attachment.html