[Building Sakai] 2.8.1 (1.2.6 kernel) stills bugs on null eid requests to LDAP

[Jean-Francois Leveque]

Hi all,

It looks like the m_provider.getUsers(usersToQueryProvider); call in 
./kernel-impl/src/main/java/org/sakaiproject/user/impl/DbUserService.java's 
getUsersByIds is not safe.

Here is the trace I get from the user's bug display:

org.sakaiproject.portal.api.PortalHandlerException: 
org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: 
javax.faces.el.EvaluationException: Error getting property 
'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at 
org.sakaiproject.portal.charon.SkinnableCharonPortal.doGet(SkinnableCharonPortal.java:862)
caused by: org.sakaiproject.tool.api.ToolException: 
javax.servlet.jsp.JspException: javax.faces.el.EvaluationException: 
Error getting property 'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at 
org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1429)
caused by: org.apache.jasper.JasperException: 
javax.servlet.jsp.JspException: javax.faces.el.EvaluationException: 
Error getting property 'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:393)
caused by: javax.servlet.ServletException: 
javax.servlet.jsp.JspException: javax.faces.el.EvaluationException: 
Error getting property 'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at 
org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:774)
caused by: javax.faces.el.EvaluationException: 
javax.faces.el.EvaluationException: Error getting property 
'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at 
com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
caused by: javax.faces.el.EvaluationException: Error getting property 
'totalComposeToList' from bean of type 
org.sakaiproject.tool.messageforums.PrivateMessagesTool: 
java.lang.RuntimeException: getUsers(): LDAPException during search [eid 
= null][result code = Connect Error][error message = null]
     at com.sun.faces.el.impl.ArraySuffix.evaluate(ArraySuffix.java:167)
caused by: java.lang.RuntimeException: getUsers(): LDAPException during 
search [eid = null][result code = Connect Error][error message = null]
     at 
org.sakaiproject.user.impl.DbUserService$DbStorage.getUsersByIds(DbUserService.java:710)
caused by: LDAPException: Connection lost waiting for results from 
annuaire.upmc.fr:389 (91) Connect Error
java.io.EOFException: BERDecoder: decode: EOF in Identifier
     at java.lang.Thread.run(Thread.java:662)
caused by: java.io.EOFException: BERDecoder: decode: EOF in Identifier
     at com.novell.ldap.asn1.ASN1Identifier.<init>(null:-1)
     at com.novell.ldap.Connection$ReaderThread.run(null:-1)
     at java.lang.Thread.run(Thread.java:662)

Cheers,

J-F