[Building Sakai] [Sakai Jira] Resolved: (SAM-1512) problems with "show feedback" and "feedback immediate" on character "

Raul Sanchez Vegas raulsv at um.es
Thu Jan 5 00:44:53 PST 2012


Hi Karen,

You're welcome.
Regards,

Raúl

El 04/01/2012 20:02, Karen Tsao escribió:
> Hi Raul,
>
> Sorry for the late reply. I was on vacation until yesterday.
>
> Thanks a lot for providing the patch. I will take a look at it today 
> and merge the fix if things look good.
>
> Karen
>
>
> On Fri, Dec 23, 2011 at 1:04 AM, Raul Sanchez Vegas <raulsv at um.es 
> <mailto:raulsv at um.es>> wrote:
>
>     Hi,
>
>     I've modified the patch "SAM1512.patch".
>
>     Now it codifies '&amp;' with '&' before the comparation between
>     the student answer and the correct answer. This is because when
>     the character " is stored like '&quot;', it is compared like
>     '&amp;quot;' but when it is stored like " it is compared like
>     '&quot;' so if we code '&amp;' with '&' the comparation is well
>     done in all cases.
>
>     Regards,
>
>     Raúl
>
>
>     El 21/12/2011 10:48, Raul Sanchez Vegas escribió:
>>     Hi Karen
>>
>>     I've attached the patch "SAM1512.patch" to be applied on the Trunk.
>>
>>     This patch decodes FIB question's correct answer before the
>>     comparation with the decoded student answer and it replaces the
>>     Microsoft Word's double quotation mark (&lquot; and &rquot;) with
>>     &quot;.
>>
>>     Regards,
>>
>>     Raúl
>>
>>
>>     El 16/12/2011 11:19, Karen Tsao escribió:
>>>     Hi Raul,
>>>
>>>     If you can provide the fix, that'll be great! Please attach it
>>>     to the JIRA. Thanks a lot for help with improving Samigo.
>>>
>>>     Karen
>>>
>>>     On Fri, Dec 16, 2011 at 12:06 AM, Raul Sanchez Vegas
>>>     <raulsv at um.es <mailto:raulsv at um.es>> wrote:
>>>
>>>         Thanks Karen
>>>
>>>         I'm going to reopen this Jira. So if you agree I could
>>>         create a patch to fix this on the trunk and attach it to the
>>>         JIRA.
>>>
>>>         Regards,
>>>
>>>         Raúl
>>>
>>>
>>>         El 14/12/2011 18:45, Karen Tsao escribió:
>>>>         Raul,
>>>>
>>>>         I understand what you mean. However, I don't have time to
>>>>         look into this at this point. Can you please reopen the
>>>>         JIRA and I will look into it later?
>>>>
>>>>         Thanks,
>>>>         Karen
>>>>
>>>>         On Wed, Dec 14, 2011 at 1:05 AM, Raul Sanchez Vegas
>>>>         <raulsv at um.es <mailto:raulsv at um.es>> wrote:
>>>>
>>>>             Hi Karen,
>>>>
>>>>             Thanks for fixing this issue.
>>>>
>>>>             I've applied the patch associated to the resolution but
>>>>             it fixes only
>>>>             the student part and not the instructor part, I mean that:
>>>>
>>>>             If we have this fill in blank question text:
>>>>
>>>>             'How many fingers do you have in your hands? {"five"}'
>>>>
>>>>             When the student writes "five" your patch decodificates
>>>>             this response
>>>>             like &amp;&quot;five&quot;&amp; and it is compared with
>>>>             the correct
>>>>             answer, but the correct answer has been stored like
>>>>             &quot;five&quot; or
>>>>             like "five", so it never matches.
>>>>
>>>>             I think that when the instructor stores the correct
>>>>             answer, the patch
>>>>             would need to decodificate the correct answer too
>>>>             before storing it into
>>>>             the database.
>>>>
>>>>             If you agree I can re-open this issue to fix this.
>>>>
>>>>             Thanks in advance,
>>>>
>>>>             Raúl
>>>>
>>>>
>>>>             El 09/12/2011 23:55, Karen Tsao (JIRA) escribió:
>>>>             >       [
>>>>             https://jira.sakaiproject.org/browse/SAM-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>>             ]
>>>>             >
>>>>             > Karen Tsao resolved SAM-1512.
>>>>             > -----------------------------
>>>>             >
>>>>             >      Fix Version/s: 2.9 [tentative]
>>>>             >         Resolution: Fixed
>>>>             >
>>>>             >> problems with "show feedback" and "feedback
>>>>             immediate" on character "
>>>>             >>
>>>>             ---------------------------------------------------------------------
>>>>             >>
>>>>             >>                  Key: SAM-1512
>>>>             >>                  URL:
>>>>             https://jira.sakaiproject.org/browse/SAM-1512
>>>>             >>              Project: Samigo
>>>>             >>           Issue Type: Bug
>>>>             >>           Components: Tests&  Quizzes (Samigo)
>>>>             >>     Affects Versions: 2.7.5
>>>>             >>             Reporter: Raúl Sánchez Vegas
>>>>             >>             Assignee: SAMIGO TEAM
>>>>             >>              Fix For: 2.9 [tentative]
>>>>             >>
>>>>             >>
>>>>             >> Hi
>>>>             >> If we have a test configurated with "feedback
>>>>             inmediate" and it has a fill in blank question whose
>>>>             correct answer contains the character ", when student,
>>>>             during assessment,  selects "show feedback" it always
>>>>             shows the wrong feedback because the question's correct
>>>>             answer has been stored with&quot; instead of character ".
>>>>             >> The question text to reproduce this could be:
>>>>             >> 'How many fingers do you have in your hand? {"five"}'
>>>>             >> Sometimes the question's correct answer that it's
>>>>             stored is&quot;five&quot;. When it happens, if student,
>>>>             during assessment, selects "show feedback" always gets
>>>>             the wrong feedback despite of writing the correct answer.
>>>>             >> We think it is a bug. Thanks
>>>>
>>>>             _______________________________________________
>>>>             sakai-dev mailing list
>>>>             sakai-dev at collab.sakaiproject.org
>>>>             <mailto:sakai-dev at collab.sakaiproject.org>
>>>>             http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>
>>>>             TO UNSUBSCRIBE: send email to
>>>>             sakai-dev-unsubscribe at collab.sakaiproject.org
>>>>             <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>
>>>>             with a subject of "unsubscribe"
>>>>
>>>>
>>>
>>>
>>
>>
>>
>>     _______________________________________________
>>     sakai-dev mailing list
>>     sakai-dev at collab.sakaiproject.org  <mailto:sakai-dev at collab.sakaiproject.org>
>>     http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>>     TO UNSUBSCRIBE: send email tosakai-dev-unsubscribe at collab.sakaiproject.org  <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org>  with a subject of "unsubscribe"
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20120105/84bbef27/attachment.html 


More information about the sakai-dev mailing list