[Building Sakai] Assignment submission issue

[Will Humphries]

I verified that this issue is still occurring on the 2.7.x test 
instance, so without the check below student submissions and instructor 
feedback can still be unintentionally disclosed and/or lost.

Zhen, do you recall any other issues that the check for a consistent 
state might have caused in the 2.7.x merge?

Thanks,
Will

On 1/31/12 3:07 PM, Aaron Zeckoski wrote:
> I believe we actually removed that because it caused other issues. I
> don't have the ticket in front of me and I am about to jump on a call
> but you may want to be careful about this.
>
> -AZ
>
>
> On Tue, Jan 31, 2012 at 3:01 PM, Will Humphries<whumphri at vt.edu>  wrote:
>> When I compared the trunk commit (r89037) to the 2.7.x merge (r92289), it
>> looked like one chunk was missed. After merging r92289, I think you'll want
>> to add the following to
>> assignment-tool/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
>> . Local testing confirms that with this extra bit of code committed, the
>> issue doesn't occur as a result of multi-tab grading.
>>
>> @@ -7895,6 +7886,11 @@
>>           ParameterParser params = data.getParameters();
>>           String sId = params.getString("submissionId");
>>
>> +        //Added by Branden Visser - Check that the state is consistent
>> +        if (!checkSubmissionStateConsistency(state, sId)) {
>> +            return false;
>> +        }
>> +
>>           // security check for allowing grading submission or not
>>           if (AssignmentService.allowGradeSubmission(sId))
>>           {
>>
>>
>>
>> On 1/31/12 11:24 AM, Geng, Kelly wrote:
>>
>> We are at r88421. I will plan for applying this patch.
>>
>>
>>
>> Thanks!
>>
>>
>>
>> Kelly
>>
>>
>>
>> From: Zhen Qian [mailto:zqian at umich.edu]
>> Sent: Tuesday, January 31, 2012 11:13 AM
>> To: Will Humphries
>> Cc: Geng, Kelly; Charles Hedrick; sakai-dev at collab.sakaiproject.org
>> Developers
>> Subject: Re: [Building Sakai] Assignment submission issue
>>
>>
>>
>> That's the right jira. Thanks for finding this out, Will!
>>
>>
>>
>> Kelly, could you please verify that whether you've got the r92289 version in
>> your 2.7.x branch?
>>
>>
>>
>> Thanks,
>>
>>
>>
>> - Zhen
>>
>>
>>
>> On Jan 31, 2012, at 11:03 AM, Will Humphries wrote:
>>
>>
>>
>> I think this was fixed in trunk r89037 , associated with SAK-13789. The
>> 2.7.x merge is r92289 if anyone's unable to review that JIRA.
>>
>> -Will
>>
>> On 1/30/12 10:40 PM, Zhen Qian wrote:
>>
>> Hi, Kelly:
>>
>>
>>
>> I found this old sakai-dev email thread about the same
>> problem: http://collab.sakaiproject.org/pipermail/sakai-dev/2011-February/011238.html
>>
>>
>>
>> Looks like Chuck had put in some investigation into the problem and thought
>> it might be triggered from instructor double clicking on the navigation
>> buttons.
>>
>>
>>
>> Chuck also mentioned a possible patch in the thread. However, I cannot find
>> any relevant jira for this. Chuck, have you applied the local patch
>> afterwards?
>>
>>
>>
>> Thanks,
>>
>>
>>
>> - Zhen
>>
>>
>>
>>
>>
>> On Jan 30, 2012, at 5:14 PM, Geng, Kelly wrote:
>>
>>
>>
>> Zhen,
>>
>>
>>
>> I got an another incident today which seems similar in nature to the last
>> one: in grading an assignment, the instructor saw 2 exactly  same
>> submissions of 2 students next to each other on the roster. She graded both
>> submissions and returned the grades(0 for both) thinking that they are
>> plagiarism, but the students were shocked and denied vehemently. So she
>> reported this issue to see whether it was a system error (or something
>> else).
>>
>>
>>
>> When I looked at the submissions table, there is only 1 submission with a
>> “submit date” and the “submitted text” in the xml file, but both have the
>> same submitted text in the “feedback text” field. It seems like only 1
>> student submitted the work, but somehow the text got copied to the other
>> student’s ‘feedback text’. But I can’t see what can possibly cause this. Now
>> this (one student’s submission gets copied to another student) has happened
>> to 2 instructors, can you think of any scenario to lead to this? I attached
>> both student’s submission xml for your reference.
>>
>>
>>
>> Thanks,
>>
>> Kelly
>>
>>
>>
>>
>>
>> From: sakai-dev-bounces at collab.sakaiproject.org [mailto:sakai-dev-bounces at collab.sakaiproject.org] On
>> Behalf Of Geng, Kelly
>> Sent: Sunday, January 29, 2012 9:10 PM
>> To: Zhen Qian
>> Cc: sakai-dev at collab.sakaiproject.org
>> Subject: Re: [Building Sakai] Assignment submission issue
>>
>>
>>
>> Thanks Zhen!
>>
>>
>>
>> Kelly
>>
>>
>>
>>
>>
>> From: Zhen Qian [mailto:zqian at umich.edu]
>> Sent: Friday, January 27, 2012 3:32 PM
>> To: Geng, Kelly
>> Cc: sakai-dev at collab.sakaiproject.org
>> Subject: Re: Assignment submission issue
>>
>>
>>
>> Kelly:
>>
>>
>>
>> Based on the xml file, the feedbacktext and feedbacktext-html fields are
>> somehow empty, while the submittedtext and submittedtext-html still contain
>> the original student submission.
>>
>>
>>
>> The feedbacktext defaults to be student submitted text at first. However,
>> instructor can add inline feedback text there and hence rewrite it. Maybe
>> during the grading period, instructor accidentally cleared the feedback text
>> field, and then released the grading to student?
>>
>>
>>
>> You can use the "Download All" feature in instructor grading view to get the
>> original student submitted text, and let instructor paste it(along with his
>> feedbacks) into the feedback text area to "restore" the student submission
>> materials.
>>
>>
>>
>> Thanks,
>>
>>
>>
>> - Zhen
>>
>>
>>
>>
>>
>> On Jan 27, 2012, at 3:07 PM, Geng, Kelly wrote:
>>
>>
>>
>> Zhen,
>>
>>
>>
>> We are running 2.7.x.  I was able to verify that the submitted text is not
>> showing(blank) in both instructor and the student’s view.
>>
>>
>>
>> I was able to decode the submitted text successfully. The student already
>> sent her saved copy to the instructor for grading but didn’t try to submit
>> it again.
>>
>>
>>
>> Kelly
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> From: Zhen Qian [mailto:zqian at umich.edu]
>> Sent: Friday, January 27, 2012 2:33 PM
>> To: Geng, Kelly
>> Cc: sakai-dev at collab.sakaiproject.org
>> Subject: Re: Assignment submission issue
>>
>>
>>
>> Hi, Kelly:
>>
>>
>>
>> What version of Sakai are you running?
>>
>>
>>
>> I did see the student submission text included in the xml file. You can use
>> Base64 decoder to view the original text, e.g. use this
>> url: http://www.opinionatedgeek.com/dotnet/tools/base64decode/
>>
>>
>>
>> Can you login as the instructor and verify the problem?
>>
>>
>>
>> Thanks,
>>
>>
>>
>> - Zhen
>>
>> On Jan 27, 2012, at 12:10 PM, Geng, Kelly wrote:
>>
>>
>>
>>
>> Zhen,
>>
>>
>>
>> We have a faculty who claims that she was reading a student’s in-line
>> submission when it changes to another student’s(the student right next in
>> the roster) submission somehow. And after she logged out and back in, the
>> original student’s submission disappeared. I looked into the
>> assignment_submission table and found the submission as attached. It seems
>> to me there WAS submitted-text recorded. Can you shed some light on this?
>>
>>
>>
>> Thanks,
>>
>> Kelly
>>
>>
>>
>> <assignment_submission_disppeared.xml>
>>
>>
>>
>>
>>
>> <ass_collinm8.xml><ass_christcr.xml>
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>>
>> sakai-dev mailing list
>>
>> sakai-dev at collab.sakaiproject.org
>>
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>>
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org
>> with a subject of "unsubscribe"
>>
>>
>>
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org
>> with a subject of "unsubscribe"
>
>