[Building Sakai] realmRoleGroupCache 100% miss.

[Steve Swinsburg]

Looks like there is a patch for it, and that it improves performance considerably. Anyone closer to this caching code able to take a look?

Quite a few cache misses means there should be room for significant gains.

Thanks
Steve

Sent from my iPad

On 17/08/2012, at 23:15, Aaron Zeckoski <azeckoski at unicon.net> wrote:

> The cache as implemented in
> https://jira.sakaiproject.org/browse/KNL-600 does not work right so it
> definitely should NOT be turned on be default. See the notes in the
> ticket for more details.
> -AZ
> 
> 
> On Fri, Aug 17, 2012 at 1:41 AM, Steve Swinsburg
> <steve.swinsburg at gmail.com> wrote:
>> Hi all,
>> 
>> In trunk and in 2.9 I'm seeing a 100% miss ratio on the following cache. This cache is not present in 2.8. I checked the 2.9 Qa servers and they show the same thing.
>> 
>> org.sakaiproject.authz.impl.DbAuthzGroupService.realmRoleGroupCache: count:0 hits:0 misses:2507 hit%:0
>> 
>> On another instance I had over 8000 misses in an hour.
>> 
>> Last change to the kernel authz-components.xml (where this cache is defined) was r105160, done in https://jira.sakaiproject.org/browse/KNL-532
>> 
>> The previous commit was where this cache definition was added which was r85976, done in https://jira.sakaiproject.org/browse/KNL-600
>> 
>> Looking through the code I see that is is controlled via this in sakai.properties, and defaults to false
>> 
>> authz.cacheGrants = true/false
>> 
>> I wonder if we should enable this one by default?
>> 
>> Dave I've copied you in since you added the cache, how has your experience been with it?
>> 
>> cheers,
>> Steve
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>> 
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
> 
> 
> 
> -- 
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile