[Building Sakai] WHAT HAPPENED TO SERVER-CONFIGURATION-SERVICE ?!?

[Jim Eng]

I am still asking that these two commits be backed out and reimplemented without reformatting parts of the files that do not need to be changed. If you do not want to do that, please say so, and I will ask for a vote.  

This pattern of reformatting an entire file when making a few changes is unacceptable, IMO.  

Jim




On Sep 13, 2011, at 6:23 PM, Aaron Zeckoski wrote:

> I think you are thinking of the use of private inner classes in
> implementations. This was a pattern that was popular with Glenn and
> others and it made things (like services) very difficult to test
> because the private classes were inaccessible and had to be
> reimplemented in order to do simple tests. Public classes whether
> inner or otherwise are generally no problem unless they are final
> (this is a hibernate pattern that is very annoying).
> If you check in the utils area you will find that I included basic
> implementations of the interfaces to make it even easier to use them
> (without requiring developers to create their own implementations to
> perform simple operations).
> 
> -AZ
> 
> 
> On Tue, Sep 13, 2011 at 6:11 PM, Jim Eng <jimeng at umich.edu> wrote:
>> It turns out that I was having problems due to stale artifacts in my local maven repo.  That was causing problems finding the inner interfaces. I would have had the same problem even if they were not inner classes.  That's fixed.
>> 
>> I use inner classes in some places.  But people had lots of problems with the inner Storage interfaces in Service classes when trying to create mocks in the early days of sakai2. Maybe I was wrong when I said you complained about that.  For a while there was general agreement not to use inner interfaces because of those problems.  Apparently those days are gone.
>> 
>> I am still asking that these two commits be backed out and reimplemented without destroying the history of the code.
>> 
>> Please.
>> 
>> Jim
>> 
>> 
>> On Sep 13, 2011, at 5:55 PM, Aaron Zeckoski wrote:
>> 
>>> I'm unaware of issues with inner class interfaces. Please explain.
>>> Thanks
>>> -AZ
>>> 
>>> 
>>> On Tue, Sep 13, 2011 at 5:53 PM, Jim Eng <jimeng at umich.edu> wrote:
>>>> Aaron, and all:
>>>> 
>>>> Yes, I am shouting!
>>>> 
>>>> It looks like two checkins were made to ServerConfigurationService recently, but I cannot tell what has changed because the entire contents of the interface was replaced though it looks like many of the methods did not change at all.  That means all history for that file is gone. Or maybe I should say useless.  We can no longer do a simple svn command to find out when a particular line of code changed and why. It looks like every single line of code except for the interface name changed in rev 98010.
>>>> 
>>>> http://source.sakaiproject.org/viewsvn/kernel/trunk/component-manager/src/main/java/org/sakaiproject/component/api/ServerConfigurationService.java?r1=66281&r2=98010&pathrev=98098
>>>> 
>>>> Then a few more changes were added in rev rev 98098.
>>>> 
>>>> http://source.sakaiproject.org/viewsvn/kernel/trunk/component-manager/src/main/java/org/sakaiproject/component/api/ServerConfigurationService.java?r1=98010&r2=98098&pathrev=98098
>>>> 
>>>> I looked this up because I am trying to update a mock in a contrib project, and someone has added inner interfaces to ServerConfigurationService, which I am having difficulty dealing with.  I thought we learned the problems with inner interfaces a long time ago, and I seem to remember Aaron Z complaining about the problems they created when implementing mocks.
>>>> 
>>>> I think revs 98010 and 98098 should be backed out until they are cleaned up.  The code should NOT be reformatted in this way that loses all of the history and masks the actual changes that are being made.  The inner interfaces should be moved out so they are separate interfaces. etc.
>>>> 
>>>> Please.
>>>> 
>>>> Jim
>>>> 
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
>>> 
>>> 
>> 
>> 
> 
> 
> 
> -- 
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
> 
>