[Building Sakai] Problem with Assignment Due Date

[Benito J. Gonzalez]

To clarify, this only occurs when an assignment is past due but the
student did not create a submission yet.  This results in the case where
a null submission object is passed to the CanResubmit() method, causing
the NPE.

On 09/12/11 11:24, Benito J. Gonzalez wrote:
> We found that the code in the BaseAssignmentService class was trying to
> use a null submission object for a test in 2.7.1 (our current version):   
>
>     The logic is that for a missing submission after the assignment is
>     due, try to see if the student can resubmit late.
>     (BaseAssignmentService.java: 5901): 
>
>                 if (submission == null || (submission != null &&
>     submission.getTimeSubmitted() == null)) 
>
>                 { 
>
>                     // if there is no submission yet 
>
>                     if ((closeTime != null &&
>     currentTime.after(closeTime)) && (*!canResubmit(submission,
>     closeTime)*)) 
>
>                     { 
>
>                         return false; 
>
>                     } 
>
>                     else 
>
>                     { 
>
>                         return true; 
>
>                     } 
>
>                 } 
>
>                 else 
>
>                 { 
>
>     ... 
>
>     It probably should be: 
>
>             if (submission == null || submission.getTimeSubmitted() ==
>     null) { 
>
>                 // if there is no submission yet 
>
>                 if (closeTime == null || closeTime.after(currentTime)) { 
>
>                     return true; // assignment not yet closed 
>
>                 } else if (submission != null && canResubmit(submission,
>     closeTime)) { 
>
>                     return true; // late but can resubmit 
>
>                 } else { 
>
>                     return false; 
>
>                 } 
>
> Is there a jira?
>
> Benito J. Gonzalez
> Manager, Enterprise Web Applications
> Information Technology Department
> University of California, Merced
> Desk: 209.228.2974
> Cell: 209.201.5052
> Email: bgonzalez2 at ucmerced.edu
>
>
> On 09/12/11 09:20, Zhen Qian wrote:
>> Same question here. 
>>
>> Omer, can you please verify this by going to the individual submission
>> grading page, and check for the "Allow Resubmission" choices at the
>> bottom of the page?
>>
>> Thanks,
>>
>> - Zhen
>> On Sep 12, 2011, at 12:14 PM, Mathieu Plourde wrote:
>>
>>> Were those students flagged to be allowed to individually resubmit?
>>> ==================================
>>> Mathieu Plourde, MBA
>>> Project Leader, LMS/Educational Technologist
>>> IT Client Support & Services
>>> mathieu at udel.edu <mailto:mathieu at udel.edu>
>>> Office: 302-831-4060
>>> ==================================
>>> IT Support Center: http://www.udel.edu/help
>>> Sakai at UD Support and Training: http://www.udel.edu/sakai/training
>>>
>>>
>>>
>>> On Mon, Sep 12, 2011 at 12:08 PM, Omer Piperdi <omer at rice.edu
>>> <mailto:omer at rice.edu>> wrote:
>>>
>>>     We are having an issue with the assignments tool accepted student
>>>     submissions after the "accept until" date has passed.  For example, a
>>>     professor set up an assignment with the following dates:
>>>     Start Date: Aug 1, 2011 12:00pm
>>>     Due Date: Sep 2, 2011 9:10am
>>>     Accept Until: Sep 5, 2011 9:10 am
>>>     Allow resubmissions until: Sep 5, 2011 9:10 am
>>>
>>>     Students were able to submit to this assignment on the following
>>>     dates:
>>>     Sep 11, 2011 10:23 pm
>>>     Sep 12, 2011 7:46 am
>>>
>>>     We have checked the XML attribute in assignment_assignment table and
>>>     looks like value are correct there as well.. Here are the date
>>>     values in
>>>     the database.
>>>
>>>        closedate="20110905141000000"
>>>         opendate="20110801170000000"
>>>          duedate="20110902141000000"
>>>     dropdeaddate="20110902141000000"
>>>
>>>     We are on 2.8.x.
>>>
>>>     Thanks
>>>     Omer
>>>     _______________________________________________
>>>     sakai-dev mailing list
>>>     sakai-dev at collab.sakaiproject.org
>>>     <mailto:sakai-dev at collab.sakaiproject.org>
>>>     http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>
>>>     TO UNSUBSCRIBE: send email to
>>>     sakai-dev-unsubscribe at collab.sakaiproject.org
>>>     <mailto:sakai-dev-unsubscribe at collab.sakaiproject.org> with a
>>>     subject of "unsubscribe"
>>>
>>>
>>> _______________________________________________
>>> sakai-dev mailing list
>>> sakai-dev at collab.sakaiproject.org
>>> <mailto:sakai-dev at collab.sakaiproject.org>
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>
>>> TO UNSUBSCRIBE: send email to
>>> sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of
>>> "unsubscribe"
>>
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"