[Building Sakai] Blockers (2.8.1/2.7.2): Samigo project

[Anthony Whyte]

Currently there are two samigo blockers that are holding up sakai-2.8.1 and each may also have implications for sakai-2.7.2.  I would like to release samigo-2.8.3 (for sakai-2.8.1) and, if necessary, samigo-2.7.5 (for sakai-2.7.2) as soon as possible once work is complete and 2.7.x related-questions are answered.  See my notes below for more details.

Note that there are another 8 samigo resolved tickets flagged for 2.8.x merging that have yet to be tested/verified.  I do not plan to include any of these fixes in the next release(s) of samigo unless they have been tested and verified.

Samigo-2.8.x (closed/resolved, to merge), n=10
https://jira.sakaiproject.org/secure/IssueNavigator.jspa?mode=hide&requestId=12804

Cheers,

Anth


BLOCKERS (n=2)
1. Javascript next/previous button handling leads to data discrepancies in FF4: https://jira.sakaiproject.org/browse/SAM-1244
	Testing by various schools indicate that the issue has been resolved, at least for 2.8.x.  However:	
	2.8.x: trunk r95454, r95460 have NOT been merged to 2.8.x.
	2.7.x: trunk r95454, r95460 have NOT been merged to 2.7.x.  Local merge conflicts reported by Will Humphries.

Current status: this issue remains a blocker.
Action required: merge to 2.8.x
Question: does samigo-2.7.x suffer from the same problem?

2.  Average scores from timed assessments linked to calculated incorrectly: https://jira.sakaiproject.org/browse/SAM-1286
	2.8.x: testing by Longsight; fix merged to 2.8.x (r97708)
	2.7.x: has the org.sakaiproject.tool.assessment.services.GradingService notifyGradebook(...) method been reviewed?

Current status: merged to 2.8.x
Question: does this issue also affect samigo-2.7.x?


NOT MERGED (testing/verification required)
* Note: none of these fixes will be merged to 2.8.x/2.7.x until fixes are tested and verified.

1. String concatenation issues: https://jira.sakaiproject.org/browse/SAM-1259
2. "feedback" string hard-coded: https://jira.sakaiproject.org/browse/SAM-1254
3. Null value for section author type generates a NumberFormatException: https://jira.sakaiproject.org/browse/SAM-1252
4. Components with Id "submissions_Allowed" and "scoringType" not found in view:  https://jira.sakaiproject.org/browse/SAM-1242
5. Email command compromises anonymity: https://jira.sakaiproject.org/browse/SAM-1234
6. Samigo test fails when attempted by 400 member class: https://jira.sakaiproject.org/browse/SAM-1119
7. "Show Intro and Part" title display/print issues: https://jira.sakaiproject.org/browse/SAM-1070


TICKETS I FIND SOMEWHAT CONFUSING

1. NPE from mailer: https://jira.sakaiproject.org/browse/SAM-1140 
2.  Emailing test takers in Chrome and Safari cause NPE: https//jira.sakaiproject.org/browse/SAM-1130

These ticket confuses me somewhat.  Listed as fixed and closed with a 2.8.x status set to merge.  However, there is nothing to merge unless one follows to the comments to SAM-1249 (fix already merge to 2.8.x).

A 23 August comment suggests that the general issue involving notifications is only partly resolved by work performed on these tickets (SAM-1130, SAM-1140, SAM-1249).

I suggest that both SAM-1140 and SAM-1130 be re-opened in order to
 a. set the 2.8.x merge status to none
 b. create explicit links with SAM-1130 and SAM-1249
 c. link to a new ticket that links back to SAM-1130, SAM-1140 and SAM-1249 in order to reflect what appears to be additional work required in order to arrive at an optimal solution based on the comment below:

"Decision for SAMigo 2.9 is to use 'mailto' since it's the best solution to date. Sam Ottenhoff from Longsight indicated that fixing the existing SAMigo email functionality would not be that difficult. "Basically, it looks like the existing functionality depends on a phantom submission from an onClick handler. This functionality could be rewritten to pass over the required information in GET variables instead.  If someone in the community would like to take on the work in the future, then please re-open and update the JIRA items."