[Building Sakai] Portal Change Breaks OSP Portal (SAK-20578, SAK-20581)

[csev]

Duffy,

Back to you - svn commit
Sending        portal-charon/charon/src/webapp/scripts/portalscripts.js
Sending        portal-render-engine-impl/pack/src/webapp/vm/defaultskin/includeStandardHead.vm
Transmitting file data ..
Committed revision 93318.

Make sure to set the merge flags when you commit your fix.

/Chuck

On May 11, 2011, at 6:24 PM, Duffy Gillman wrote:

> Eeek! Apologies folks... that should be SAK-20578, not SAK-20576.
> 
> 
>> On May 11, 2011, at 6:04 PM, Duffy Gillman <duffy at rsmart.com> wrote:
>> 
>>> To fix a critical bug in OSP portal I need to make a refactoring of code within the standard portal. I have a patch attached to the Jira issue SAK-20576, but I would like someone more closely involved in maintenance of the standard portal to review it to make sure it makes sense (thus, SAK-20581).
>>> 
>>> Brief Synopsis:
>>> 
>>> A change made to the Portal project for SAK-16484 broke the OSP Portal. The Portal includes a javascript library, portalscripts.js. For SAK-16484 many of the state variables in portalscripts.js were gathered together into an associative array called 'portal'. However the variable 'portal' is *not* declared in portalscripts.js; instead it is declared in a Velocity macro called incudeStandardHead.vm within the standard Portal rendering project. This means that the portalscripts.js will cause JavaScript errors if includeStandardHead.vm is not the source of the HTML that includes portalscripts.js. In other words, the only renderer that can use portalscripts.js without the Javascript error is the standard portal.
>>> 
>>> In most browsers this problem is ignored, but in IE 8 the portal becomes unusable. This breaks the OSP Portal in IE 8.
>>> 
>>> The submitted patch moves the definition of 'portal' into portalscripts.js so that that script can stand alone. The patch then provides methods that can be called from includeStandardHead.vm to set the variables contained within the 'portal' associative array.
>>> _______________________________________________
>>> sakai-dev mailing list
>>> sakai-dev at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>> 
>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>> 
> 
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> 
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
> 
>