[Building Sakai] upload/download attachment neglect !site.helper

[Qu, Yuanhua]

Thanks Bryan.

You are right,  SAK-6361 does described same thing as I mentioned in SAK-20420 and the fix works so that site permission remains after a permission "save" in the site when !site.helper have the same permission.  Wish that fix could get into the main source code so that the issue won't occur again.

https://jira.sakaiproject.org/browse/SAK-20441  is a different bug I believe and also still exists in trunk. Easily reproduce.  I put a patch there.

We applied the two patches, works fine now.

Thanks again for your help.

-Qu




On 4/11/11 7:03 PM, "Bryan Bakotich" <bakotibj at plu.edu> wrote:

Qu,

It sounds like you are describing this error: https://jira.sakaiproject.org/browse/SAK-6361

I have used the suggested patch in the second comment on that issue and it works fine for us.

-Bryan

On Mon, Apr 11, 2011 at 11:41 AM, Qu, Yuanhua <yq12 at txstate.edu> wrote:
We run into error for upload/downlaod attachment in several tools ( Ex: Forums, Samigo, Assignment ) when our instructor did some permission changes in Resources Tool when we also have same permission checked in !site.helper for each role.  I did investigation for the last week and found out there are two bugs in all the 2.x versions and also sakai's trunk.

I created two JIRAs that caused this issue:

One is https://jira.sakaiproject.org/browse/SAK-20420;
The other is  https://jira.sakaiproject.org/browse/SAK-20441

I got the fix patch for the second JIRA, but need expert to see if I didn't bring in anything extra.   I tried to work on the first one SAK-20420 but hard to find the right place although I know the fix should be only updating the content.* permission that are actually changeable or in another word, skipping those permissions that checked in the helper realm and only update rest of content.* for each role.  Any pointers?

Thanks.

-Qu




_______________________________________________
sakai-dev mailing list
sakai-dev at collab.sakaiproject.org
http://collab.sakaiproject.org/mailman/listinfo/sakai-dev

TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20110412/0ca60721/attachment.html