[Building Sakai] content-review is broken in 2.7?

[David Horwitz]

Yes this is the minimum generic-dao version needed with 2.7 and later
(due to the spring upgrade) it is backwards compatible. I've hit other
tools with this issue (lams, signup) recently.

Regards

David

On 10/13/2010 12:54 AM, Hedrick Charles wrote:
> It looks like our fix was to change generic dao version from 0.9.8 to
> 0.9.17
>
> On Oct 12, 2010, at 6:11:44 PM, Adrian Fish wrote:
>
>> Charles,
>>
>> Did you ever get anywhere with this? I'm having the same grief ...
>>
>> Cheers,
>>
>> Adrian.
>>
>> On 29/03/2010 20:33, Charles Hedrick wrote:
>>> Hmmm.... wrong version of generic-dao. Very odd error message for that error.
>>>
>>> On Mar 29, 2010, at 2:28:59 PM, Charles Hedrick wrote:
>>>
>>>       
>>>> We use the turnitin content-review module. In 2.7, something has been done to ContentReviewDao that I can't make sense of.
>>>>
>>>>   <!-- This wraps our DAO so that the transactions are managed -->^M
>>>>                <bean id="org.sakaiproject.contentreview.dao.ContentReviewDao"
>>>>                        class="org.sakaiproject.genericdao.springutil.CurrentClassLoaderTxProxyFactoryBean">
>>>>                <property name="transactionManager"
>>>>                        ref="org.sakaiproject.springframework.orm.hibernate.GlobalTransactionManager" />
>>>>                <property name="target"
>>>>                        ref="org.sakaiproject.contentreview.dao.impl.ContentReviewDaoTarget" />
>>>> ...
>>>>
>>>> The problem is that the code wants to do
>>>>
>>>>       <bean
>>>>                id="org.sakaiproject.contentreview.service.ContentReviewService"
>>>>                class="org.sakaiproject.contentreview.impl.turnitin.TurnitinReviewServiceImpl"
>>>>                init-method="init">^M
>>>>                <property name="dao"
>>>>                        ref="org.sakaiproject.contentreview.dao.ContentReviewDao" />^M
>>>>                <property name="toolManager"
>>>>                        ref="org.sakaiproject.tool.api.ToolManager" />^M
>>>>
>>>> But that can't work, because org.sakaiproject.contentreview.dao.ContentReviewDao is now an interceptor, not the actual ContentReviewDao, and so
>>>>
>>>>  public void setDao(ContentReviewDao dao) {
>>>>                super.setDao(dao);
>>>>                this.dao = dao;
>>>> }
>>>>
>>>> no longer works. I have been unable to this particular method of wrapping in documentation, so I can't tell how it was intended to work,, and it doesn't appear that any other part of Sakai uses org.sakaiproject.genericdao.springutil.CurrentClassLoaderTxProxyFactoryBean. Could whoever invented this monster please tell me how it's supposed to be used?
>>>>
>>>> _______________________________________________
>>>> sakai-dev mailing list
>>>> sakai-dev at collab.sakaiproject.org
>>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>>
>>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>>>         
>>>
>>>
>>> _______________________________________________
>>> sakai-dev mailing list
>>> sakai-dev at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>>
>>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>
>> -- 
>> ==================================
>> Adrian Fish
>> Software Engineer
>> Centre for e-Science
>> Bowland Tower South C Floor
>> Lancaster University
>> Lancaster
>> LA1 4YW
>> email: a.fish at lancaster.ac.uk
>>
>> http://confluence.sakaiproject.org/display/YAFT/Yaft
>> http://confluence.sakaiproject.org/display/CLOG/Home
>> http://confluence.sakaiproject.org/display/BBB/Home
>>     
>> <a_fish.vcf>
>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20101013/33d31ff6/attachment.html