[Building Sakai] Change Notice: SecurityService - deprecation and new Method

[David Horwitz]

Hi All,

Some changes to the security service:

Security.clearAdvisors() has been marked deprecated. This method can 
clear advisors set by other methods in the calling thread leading to 
hard to debug permission exceptions. This method has been marked as 
deprecated in all the kernel branches and the deprecation and warning 
will be included in the next releases of the 1.0 and 1.1 kernels. Thanks 
to Matthew Buckett and Zhen Qian all uses of these in the core Sakai 
code where fixed for the 2.7.0 release and will be included in the 
upcoming 2.6.3 release.  Developers are urged to check contrib and local 
code and rather use SecurityService.popAdvisor().


A new method SecurityService.popAdvisor(SecurityAdvisor) - the existing 
design of SecurityService.popAdvisor() would theoretically allow a user 
to still clear another method's advisor for example by calling this 
method on a code path where its own security advisor had not been set. 
As this is now the recommended method for clearing a security advisor 
the SecurityService.popAdvisor() has been marked as deprecated.

Regards