[Building Sakai] EmailService, SSL, TLS

[Adrian Fish]

Hi David, Carl,

Why not just change m_smtpUseSSL to m_smtpUseTLS as well as changing the 
name of the sakai.properties prop to smtpUseTLS? smtpUseSSL was a bad 
choice of parameter name; I hold my hand up :) It is off by default 
though, isn't it? If the parameter is not specified, or is false, the 
property is not set.

Cheers,

Adrian.

David Horwitz wrote:
> Hi Carl,
>
> Quite right that should be off by default - will you jira and I'll fix it.
>
> D
>
> carl.hall at gatech.edu wrote:
>   
>> I happened to notice in the email service that the following exists:
>>
>> if(m_smtpUseSSL)
>>   props.put("mail.smtp.starttls.enable", "true");
>>
>> I believe this is not quite right.  Using SSL takes a little more setup work and doesn't imply TLS.  I don't mind putting in a patch for this but wanted to make sure I'm not missing something here.  Can someone else confirm this, please?
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>   
>>     
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
>   

-- 
==================================
Adrian Fish
Software Engineer
Centre for e-Science
Bowland Tower South C Floor
Lancaster University
Lancaster
LA1 4YW
email: a.fish at lancaster.ac.uk

http://confluence.sakaiproject.org/display/YAFT/Yaft
http://confluence.sakaiproject.org/display/BLOG/Home
http://confluence.sakaiproject.org/display/AGORA/Home

-------------- next part --------------
A non-text attachment was scrubbed...
Name: a_fish.vcf
Type: text/x-vcard
Size: 289 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20090921/0d4248c1/attachment.vcf