[Building Sakai] View Site in Different Role Potential Improvement [Resend]

[Stephen Marquard]

Hi,

I haven't reviewed the code line-by-line, but am satisfied that it's a targetted fix to the original code contributed by IU, and that the risk of introducing regressions elsewhere is negligible.

I'm also assuming that IU is expressing its confidence in this code by running it in production in the near future.

So +1 from me.

Regards
Stephen

>>> "May, Megan Marie" <mmmay at indiana.edu> 2009/03/12 03:55 PM >>>
Folks,
    Are there any comments on this?    This impacts the 2.6 release so it'd be good to come to some kind of common understanding.

Megan

From: Gregory J Thomas [mailto:gjthomas at iupui.edu] 
Sent: Tuesday, March 03, 2009 9:53 AM
To: sakai-dev Dev
Subject: View Site in Different Role Potential Improvement [Resend]

Hi all,

Sorry if this is a repeat.

I am writing this message to draw attention to a bug fix/improvement
with the 2.6 feature of viewing a site as if you were a different role
and to try to get support to get it into the 2.6 release.

I've created two jiras (although for 2.6 the code only affects kernel)
for folks to look at with a kernel patch attached to them.

http://bugs.sakaiproject.org/jira/browse/SAK-15753 
http://jira.sakaiproject.org/jira/browse/KNL-130 

This change fixes a related bug I was working on, but at the same time
it changes one of the key areas of how this feature works. A brief
summary is one of the isAllowed() functions located in
DbAuthzGroupService in the authz tool was only checking the base site id
for specific permission checks on the given role instead of every realm
that is passed into the function. While the old way works how we want
the vast majority of the time, the newer way is more thorough and suits
the spirit of what the function is trying to accomplish.

I would highly appreciate it to get the community to look at this and
potentially get the approval to get it into the 2.6 release.

Thanks!
Greg Thomas
________________________________

This automatic notification message was sent by Sakai Collab (https://collab.sakaiproject.org//portal<https://collab.sakaiproject.org/portal>) from the DG: Development / Building Sakai site.
You can modify how you receive notifications at My Workspace > Preferences.