[Building Sakai] K1 - uitils rationalization?

[Jim Eng]

-1 for "remove". +1 for "deprecate".


On Jun 7, 2009, at 10:37 AM, David Haines wrote:

> +1
>
>
> David Haines
> CTools Developer
> Digital Media Commons
> University of Michigan
> dlhaines at umich.edu
>
>
>
> On Jun 5, 2009, at 5:05 AM, David Horwitz wrote:
>
>> Hi All,
>>
>> I was looking at the utils classes in the K1 kernel and it strikes me
>> that we could do with some rationalization in this area to achieve:
>>
>> 1) Remove duplicated functionality
>> 2) Remove custom Sakai code that has the same functionality as  
>> standard
>> java classes (specifically Apache commons libraries)
>>
>>
>> Some of the ones I noticed:
>>
>>
>> 1) EmptyIterator - present in commons-collections
>> 2) Web.escapeJsQuotes & Validator.escapeJsQuoted() - duplicate  
>> code, in
>> commons-lang StringEscapeUtils, one marked deprecated and buggy  
>> (KNL-69)
>> 3) Validator.escapeSql in commons-lang StringEscapeUtils
>> 4) Validator.esapceJavascript in commons-lang StringEscapeUtils
>> 5) Validator.checkEmailLocal in commons-validator
>> 6) StringUtils.split - "Like jdk1.4's String.split..." the javadoc  
>> says
>> it all this is now in the jvm
>> 7) StringUtils.trimToNull & StringUtils.trimToEmpty
>>
>> This is just a quick survey and I'm sure there more. I Propose that  
>> we
>> start by marking all these as deprecated and point people the the
>> commons implementation. Thoughts?
>>
>>
>> David
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org 
>>  with a subject of "unsubscribe"
>>
>>
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org 
>  with a subject of "unsubscribe"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/sakai-dev/attachments/20090607/0ceb9c00/attachment.html