[Building Sakai] gradebook2 and 2.6

[john.bush at rsmart.com]

Ok there's a way others are using profiles to have one pom version but  
it doesn't work in our build and I haven't had time to figure it out  
quite yet

On Aug 26, 2009, at 4:24 PM, James Renfro <jlrenfro at ucdavis.edu> wrote:

> I'm not positive what IS_EXCLUDED_FROM_GRADE in 2.6 is... this might  
> be a change that Indiana has made or it might even be from our  
> earlier attempt to get some of our changes into 2.6. What you did  
> sounds right, but I'll have to sit down with the 2.6 gradebook1 for  
> a bit and check it over to be sure.
>
> In terms of getting rid of the GWT property, our long-term plan is  
> to compile the GWT code in advance and check it in as the  
> generated .html files once we move up to GWT 1.7/GXT 2.0 -- this is  
> probably going to come in for version 1.2 sometime in September/ 
> October timeframe.
>
> We should probably touch base about how to bring your work into  
> trunk gradebook2 and how to organize so we can easily maintain 2.5  
> and 2.6 compatible versions. Ideally I'd like to keep trunk  
> compatible with both, with probably two different patches and two  
> different sql scripts split out in 2.5.x and 2.6.x directories.
>
>
>
>
> John Bush wrote:
>> so I've been doing some work to port gradebook2 to 2.6, I've got it  
>> running.  But there was one hiccup I ran into and I'm not sure I  
>> took the right course of action.
>>
>> It concerns the following item in the patch to the existing gradebook
>>
>> Index: service/hibernate/src/hibernate/org/sakaiproject/tool/ 
>> gradebook/GradeRecord.hbm.xml
>> ===================================================================
>> --- service/hibernate/src/hibernate/org/sakaiproject/tool/gradebook/ 
>> GradeRecord.hbm.xml    (revision 7234)
>> +++ service/hibernate/src/hibernate/org/sakaiproject/tool/gradebook/ 
>> GradeRecord.hbm.xml    (working copy)
>> @@ -30,6 +30,7 @@
>>
>>         <subclass  
>> name="org.sakaiproject.tool.gradebook.AssignmentGradeRecord"   
>> discriminator-value="1">
>>             <property name="pointsEarned" column="POINTS_EARNED"  
>> type="double" not-null="false" />
>> +            <property name="excluded" column="EXCLUDED"  
>> type="boolean" not-null="false" />
>>         </subclass>
>>
>>         <subclass  
>> name="org.sakaiproject.tool.gradebook.CourseGradeRecord"  
>> discriminator-value="2">
>>
>> There is already a field in GradeRecord.hbm.xml     that sounds  
>> like the same thing:
>>
>> name="excludedFromGrade" column="IS_EXCLUDED_FROM_GRADE"
>>
>> So with that assumption I didn't add it to the existing hbm but  
>> rather just created accessors in AssignmentGradeRecord, like this:
>>
>>    public Boolean isExcluded() {
>>        return isExcludedFromGrade();
>>    }
>>
>>    public void setExcluded(Boolean excluded) {
>>        setExcludedFromGrade(excluded);
>>    }
>>
>> This was to avoid changing any gradebook2 code, alternatively I  
>> could refactor all the method calls there.  Best course of action?
>>
>> I'm assuming the plan is to remove the necessity of the gradebook  
>> patch in 2.7?  Has that work been done yet ?
>>
>> Also has any researched a way to remove the gwt property that you  
>> send to maven, that is pretty annoying, but I'd imagine it could  
>> cycle into many hours of work trying to figure out a way around it.
>>
>> John Bush
>> Development Manager
>> rSmart
>>
>>
>>
>>
>>