[Building Sakai] gradebook2 and 2.6
John Bush
john.bush at rsmart.com
Wed Aug 26 14:53:03 PDT 2009
so I've been doing some work to port gradebook2 to 2.6, I've got it
running. But there was one hiccup I ran into and I'm not sure I took
the right course of action.
It concerns the following item in the patch to the existing gradebook
Index: service/hibernate/src/hibernate/org/sakaiproject/tool/gradebook/
GradeRecord.hbm.xml
===================================================================
--- service/hibernate/src/hibernate/org/sakaiproject/tool/gradebook/
GradeRecord.hbm.xml (revision 7234)
+++ service/hibernate/src/hibernate/org/sakaiproject/tool/gradebook/
GradeRecord.hbm.xml (working copy)
@@ -30,6 +30,7 @@
<subclass
name="org.sakaiproject.tool.gradebook.AssignmentGradeRecord"
discriminator-value="1">
<property name="pointsEarned" column="POINTS_EARNED"
type="double" not-null="false" />
+ <property name="excluded" column="EXCLUDED" type="boolean" not-
null="false" />
</subclass>
<subclass name="org.sakaiproject.tool.gradebook.CourseGradeRecord"
discriminator-value="2">
There is already a field in GradeRecord.hbm.xml that sounds like the
same thing:
name="excludedFromGrade" column="IS_EXCLUDED_FROM_GRADE"
So with that assumption I didn't add it to the existing hbm but rather
just created accessors in AssignmentGradeRecord, like this:
public Boolean isExcluded() {
return isExcludedFromGrade();
}
public void setExcluded(Boolean excluded) {
setExcludedFromGrade(excluded);
}
This was to avoid changing any gradebook2 code, alternatively I could
refactor all the method calls there. Best course of action?
I'm assuming the plan is to remove the necessity of the gradebook
patch in 2.7? Has that work been done yet ?
Also has any researched a way to remove the gwt property that you send
to maven, that is pretty annoying, but I'd imagine it could cycle into
many hours of work trying to figure out a way around it.
John Bush
Development Manager
rSmart
More information about the sakai-dev
mailing list