[Building Sakai] 2.6.x getCurrentAcademicSessions problem

[Ray Davis]

Wow, if Zach thinks he's missing something obvious and Jon thinks he's 
having a stroke, things are pretty bad!  :)

* Since this was improved functionality that combined a DB change and an 
API change, I didn't request that it go into 2.5.x. Others can make that 
argument if they want.

* There's no "isCurrent()" or "setCurrent(boolean)" on the 
AcademicSession, true. The original read-only CourseManagementService 
API supplied:

   List<AcademicSession> getCurrentAcademicSessions()

And so I just added the equivalent method to the write-only 
CourseManagementAdministration API:

   setCurrentAcademicSessions(List<String> academicSessionEids)

This minimized changes to the existing API, which seemed important to me 
given that the interface may have been locally re-implemented by 
multiple institutions.

Best,
Ray

On 4/22/2009 12:04 PM, Jon Gorrono wrote:
> None of this seems to have ever made to the 2-5-x
> 
> also, the AcademicSession model object API doesn't have isCurrent() AFAICS
> 
> Is that right, or am I in the throes of a stroke :)
> 
> 
> On Wed, Apr 22, 2009 at 9:46 AM, Ray Davis <ray at media.berkeley.edu> wrote:
>> Well, "something obvious" isn't exactly the phrase I'd use :)  but yes,
>> this DB change is linked to an API change. See:
>>
>> http://jira.sakaiproject.org/jira/browse/SAK-12883
>> http://source.sakaiproject.org/viewsvn/course-management/trunk/cm-api/api/src/java/org/sakaiproject/coursemanagement/api/CourseManagementAdministration.java?p2=%2Fcourse-management%2Ftrunk%2Fcm-api%2Fapi%2Fsrc%2Fjava%2Forg%2Fsakaiproject%2Fcoursemanagement%2Fapi%2FCourseManagementAdministration.java&p1=%2Fcourse-management%2Ftrunk%2Fcm-api%2Fapi%2Fsrc%2Fjava%2Forg%2Fsakaiproject%2Fcoursemanagement%2Fapi%2FCourseManagementAdministration.java&r1=40843&r2=40842&view=diff&pathrev=40843
>>
>> Best,
>> Ray
>>
>> On 4/22/2009 9:35 AM, Zach A. Thomas wrote:
>>> I'm just starting to do some projects in Sakai 2.6.x, and something
>>> has come up with course-management that looks like a bug, but maybe I
>>> just don't know what I'm talking about.
>>>
>>> In the Hibernate course management implementation,
>>> AcademicSessionCmImpl has a new property "boolean current" since 2.5.x
>>> and a corresponding column in the database table it creates. It has a
>>> new query for looking up current academic sessions that just looks for
>>> IS_CURRENT = true.
>>>
>>> This all seems reasonable enough, except that there is nothing in the
>>> AcademicSession interface to allow you to get or set this property,
>>> nor does AcademicSessionCmImpl have a constructor that includes this
>>> property. IS_CURRENT is false by default, with the result being that
>>> courseManagementService.getCurrentAcademicSessions() always returns an
>>> empty list.
>>>
>>> Anyone else seen this already? Have I overlooked something obvious?
>>>
>>> cheers,
>>> Zach Thomas
>>> Owner, Aeroplane Software LLC
>>> http://aeroplanesoftware.com
>> _______________________________________________
>> sakai-dev mailing list
>> sakai-dev at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>>
>> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>>
> 
> 
>