[sakai-core-team] whitespace changes

[Matthew Buckett]

More value from the git blame than I feel I lose from the inconsistent
formatting.

On 27 February 2015 at 13:49, Bryan Holladay <holladay at longsight.com> wrote:
> ha I did notice a lot of JS formatting corrections on my code from you ;)
> I'll try better in the future and I blame Eclipse.
>
> I've always been in the anti-format changing party. It removes the history
> (e.g. blame) and makes merging incredibly hard (custom branches, maintenance
> branches, etc.). If you are working in a block of code that is formatted
> terribly, then go ahead and fix the formatting. If you're just cleaning up,
> then don't. Also, don't re-organize imports (no matter how tempting that
> is).
>
> On Thu, Feb 26, 2015 at 5:12 PM, Robert Long <rlong at unicon.net> wrote:
>>
>> I am all for changing the formatting, etc. as long as it means spaces and
>> non-hanging braces are the standard... and actually enforced! (This would go
>> along way to curing my code formatting OCD I have...)
>>
>> Just my 2¢
>>
>> --Bob
>>
>> ----
>> Robert Long
>> Software Engineer
>> Technical Account Manager - Sakai
>> Unicon, Inc.
>>
>> ----
>> M.A., Instructional Technology
>> Saginaw Valley State University
>>
>> On Feb 26, 2015, at 14:58, Sam Ottenhoff <ottenhoff at longsight.com> wrote:
>>
>> Ideally, this would have been done during the move from SVN to Git and
>> before lots of people forked sakaiproject/sakai.git.  We should have
>> globally modified all Java code as described in the link below, and then we
>> should have set up a plan to enforce standards via pull request validation.
>>
>>
>> http://stackoverflow.com/questions/4112410/git-change-styling-whitespace-without-changing-ownership-blame
>>
>> The problem with formatting changes is that it's a history killer.  git
>> blame and git diff lose their relevancy.
>>
>> How upsetting would it be for all of the Git forks if we rewrote the
>> entire history as described in that StackOverflow post?
>>
>> On Mon, Feb 23, 2015 at 12:19 PM, Brian Jones <bjones86 at uwo.ca> wrote:
>>>
>>> Hi Core Team,
>>>
>>> What is the best/accepted process for correcting whitespace
>>> inconsistencies in file(s) now that we've moved to Github?
>>>
>>> For example, if I'm working through something, and I notice a file has
>>> mixed tabs vs spaces; it's annoying me and I'd like to just fix it.
>>>
>>> Should I make a PR purely for the whitespace change to keep it separate
>>> from the feature I'm working on? Do I need to link it to a new Jira that
>>> is only for the whitespace changes?
>>>
>>> Thanks for your input!
>>> --
>>> Brian Jones
>>> Programmer/Analyst
>>> Information Technology Services
>>> Support Services Building, Suite 4300
>>> Western University
>>> (519) 661-2111 x86969
>>> bjones86 at uwo.ca
>>> _______________________________________________
>>> sakai-core-team mailing list
>>> sakai-core-team at collab.sakaiproject.org
>>> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
>>
>>
>> _______________________________________________
>> sakai-core-team mailing list
>> sakai-core-team at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
>>
>>
>>
>> _______________________________________________
>> sakai-core-team mailing list
>> sakai-core-team at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
>>
>
>
> _______________________________________________
> sakai-core-team mailing list
> sakai-core-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-core-team
>



-- 
  Matthew Buckett, VLE Developer, IT Services, University of Oxford