[WG: I18N & L10N] [Building Sakai] SAK-21908, Non-latin Chinese/Japanese characters are not supported in PDF file

[Aaron Zeckoski]

Quick review notes related to the kernel changes:

1) The way this is written, it looks like it only works for jp and zh
locales? Why is that? Is there a reason no other locales would want to
do this? I suggest removing the restriction or explaining it.

2) No javadocs to explain how this should work. In fact, no code
comments at all (not even one line). Method comments are required at
absolute minimum.

3) This adds in the org.apache.xmlgraphics depedency to the resource
loader which means that every sakai tool and most components (anything
using kernel-utils) will end up with a copy of this library loaded
into their classloader. That's a 3.0 MB jar so this will result in a
substantial increase (+100MB or more depending on what is deployed) in
the memory footprint required for Sakai instances to run. By
comparison, the hibernate jar is 2.3 MB.
For functionality which is used by a small portion of Sakai users, I
think this is probably unacceptable.
This probably needs to be rewritten to use a provider style mechanism
and an actual kernel service which does the processing so the jar is
only loaded in the service. Alternatively, rewriting this to not use
such a large library would also be acceptable.

-AZ


On Thu, May 31, 2012 at 12:07 PM, DAVID ROLDAN MARTINEZ
<darolmar at upvnet.upv.es> wrote:
> Hi,
>
> Here are my solutions. I've extended org.sakaiproject.util.ResourceLoader to get pdf font depending on the locale. On the other side, I've changed site-manage tool to get font substitutions from ResourceLoader.
> Note that pdf.default.font=AR PL UMing CN should be added to sakai.properties.
>
> I've also attached these two patches at http://jira.sakaiproject.org/browse/SAK-21909 (the site-manage tool bug).
>
> I would appreciate if somebody from KNL team reviews and applies the kernel part of this patch.
>
> Thanks a lot in advance.
>
> Cheers,
>   David
> ________________________________________
> De: i18n-bounces at collab.sakaiproject.org [i18n-bounces at collab.sakaiproject.org] en nombre de DAVID ROLDAN MARTINEZ [darolmar at upvnet.upv.es]
> Enviado el: martes, 29 de mayo de 2012 23:12
> Para: Shoji Kajita
> CC: i18n at collab.sakaiproject.org; sakai-dev at collab.sakaiproject.org
> Asunto: Re: [WG: I18N & L10N] SAK-21908, Non-latin Chinese/Japanese characters are not supported in PDF file
>
> OK. I'll do like Matthew suggest. I'll extend ResourceLoader at kernet-util to give the font depending on the locale.
>
> I'll let you know as soon as I have something to test.
>
> Thanks a lot for your feeback!!
>
> David
> ________________________________________
> De: Shoji Kajita [kajita at nagoya-u.jp]
> Enviado el: martes, 29 de mayo de 2012 16:56
> Para: DAVID ROLDAN MARTINEZ
> CC: sakai-dev at collab.sakaiproject.org; i18n at collab.sakaiproject.org
> Asunto: Re: [WG: I18N & L10N] SAK-21908, Non-latin Chinese/Japanese characters are not supported in PDF file
>
> Hi David,
>
> I think that Japanese users prefer admin level font selection, rather
> than the use of User Preferences tool to allow users to change the
> font setting.
>
> Aaron's proposal is fitting for our needs.
>
> Best regards,
> Shoji at Kyoto
>
> At Mon, 28 May 2012 15:38:53 +0000,
> DAVID ROLDAN MARTINEZ wrote:
>>
>>
>> Dear all,
>>
>> I'm working at https://jira.sakaiproject.org/browse/SAK-21908 trying to figure out which is the best way to share Font substitution utils as Aaron has suggested (thanks!) in his comments.
>>
>> My concern is if it would be useful to include font preferences at User Preferences tool and I would like to hear opinions about that possiblity. From my point of view, it should be nice to allow user to choose their own font together with other options. We did it for a11y options in a research project and looked like this (the screenshot it's in Spanish):
>>
>> [cid:image001.png at 01CD3CF8.BFB5EFA0]
>>
>> The Sakai modified codebase of this project is available at http://www.eu4all-project.eu/sites/default/files/content-files/page/11/03/eu4allandsakaiinstallation.pdf.
>>
>> Thank you very much in advance.
>>
>> Cheers,
>>    David
> _______________________________________________
> i18n mailing list
> i18n at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/i18n
>
> TO UNSUBSCRIBE: send email to i18n-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
>
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"



-- 
Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile