[WG: I18N & L10N] Best way to handle seemingly unused i18n key/value pairs

Jean-Francois Leveque jean-francois.leveque at upmc.fr
Thu Jul 12 04:53:46 PDT 2012


I think I need help to be sure about the "truly" part of being unused. 
This is why I was asking about the best way.

Grep on the entire code won't work because i18n keys are not unique and 
tracking the exact bundle where the key is requested will be really time 
consuming.

Cheers,
J-F

On 12/07/2012 12:05, Steve Swinsburg wrote:
> If they are truly unused, just remove them and submit a patch/commit it. No need to comment out, the Jira will track the reasoning and the svn log will track the code.
>
> I'd grep the entire code base though in case there are other places using them, though it's unlikely.
>
> Cheers,
> Steve
>
> Sent from my iPad
>
> On 12/07/2012, at 20:00, Jean-Francois Leveque<jean-francois.leveque at upmc.fr>  wrote:
>
>> Hi,
>>
>> This email begins with an example and ends with a general question.
>>
>>
>> I've reviewed the content of trunk's
>> access/access-impl/impl/src/bundle/access.properties which has been
>> unchanged for 5 years and 3 months.
>>
>> Out of the 23 key/value pairs at r27977, it seems 13 are currently unused:
>> java.acccess
>> java.theresource
>> java.youdonot
>> java.miss
>> java.busy
>> java.message
>> java.from
>> java.date
>> java.subject
>> java.attach
>> error.thereq
>> error.isnot
>> error.access
>>
>> This file revision log is short but, while I'm almost sure Glenn Golden
>> doesn't have time for this anymore, I wonder if it would be a good idea
>> to ask Gonzalo Silverio or Lance Speelmon for help.
>>
>> Please note I'm gonna be in the log soon because of a bug fix commit
>> that will happen soon.
>>
>>
>> What do you think is the best general way to double-check unused i18n
>> key/value pairs?
>>
>> Do you think I should:
>> - Wait for the arrival of the CLE Community Coordinator and ask him how
>> we should handle this
>> - Ask on sakai-dev for volunteers to check if I'm right
>> - Ask previous commit authors that have been active in the past year
>> - Ask another person/group
>> - Go ahead and comment-out all those seemingly unused pairs
>>
>> You can choose several options with an order and some timing if you want.
>>
>> Feel free to send a copy to sakai-dev if you think we need to ask a
>> larger crowd.
>>
>> Cheers,
>>
>> J-F


More information about the i18n mailing list