[WG: I18N & L10N] [Building Sakai] i18n strings merged with java code instead of using ResourceLoader.getFormattedMessage()

[Anthony Whyte]

I grep'd all of trunk (including all indies) after an svn update and I've found many more references to addAlert(state, rb.getString('somehardcodedstring') than what you found earlier.  See *.txt attached.  I've made no attempt to examine the allegedly offending lines that have been returned -- I'll leave that to you to review and Jira as appropriate.

find . -type f -name '*.java' | xargs grep -i 'addAlert(state, rb.getString(' | cat > /Users/arwhyte/Desktop/sakai-i18n-fix.txt

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sakai-i18n-fix.txt
Url: http://collab.sakaiproject.org/pipermail/i18n/attachments/20101202/b29bf90d/attachment-0001.txt 
-------------- next part --------------


Cheers,

Anth



On Dec 2, 2010, at 10:41 AM, DAVID ROLDAN MARTINEZ wrote:

> Done: http://jira.sakaiproject.org/browse/SAK-19627
> 
> Do you want me to help? Just let me know.
> 
> David
> 
> -----Mensaje original-----
> De: Zach A. Thomas [mailto:zach at aeroplanesoftware.com] 
> Enviado el: jueves, 02 de diciembre de 2010 16:35
> Para: DAVID ROLDAN MARTINEZ
> CC: sakai-dev at collab.sakaiproject.org; i18n at collab.sakaiproject.org
> Asunto: Re: [Building Sakai] i18n strings merged with java code instead of using ResourceLoader.getFormattedMessage()
> 
> Hi, David. I fixed a chunk of the ones in content yesterday as part of SAK-19012.
> 
> Since I have commit on the content module, I can fix the rest of the content ones. Could you create a JIRA for this and assign it to me?
> 
> many thanks,
> Zach
> On Dec 2, 2010, at 3:28 AM, DAVID ROLDAN MARTINEZ wrote:
> 
>> Hi all,  
>> 
>>      I've found too much i18n strings merged with java code instead of using ResourceLoader.getFormattedMessage(). As you can see athttp://confluence.sakaiproject.org/display/I18N/Best+Practices+for+In, this is not a good practice and has to be avoided.
>> 
>>      I would be very pleased to help tool leaders/developers to fix it. Here you have the tools that need an i18n review, as soon as possible. During next few days I'll be working on this and fix it in trunk. I would appreciate any volunteer to help me.
> 
> _______________________________________________
> sakai-dev mailing list
> sakai-dev at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/sakai-dev
> 
> TO UNSUBSCRIBE: send email to sakai-dev-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3829 bytes
Desc: not available
Url : http://collab.sakaiproject.org/pipermail/i18n/attachments/20101202/b29bf90d/attachment-0001.bin