[WG: I18N & L10N] i18n strings merged with java code instead of using ResourceLoader.getFormattedMessage()

DAVID ROLDAN MARTINEZ darolmar at upvnet.upv.es
Thu Dec 2 01:28:37 PST 2010


 
       Hi all,  

       I've found too much i18n strings merged with java code instead of using ResourceLoader.getFormattedMessage(). As you can see at http://confluence.sakaiproject.org/display/I18N/Best+Practices+for+In, this is not a good practice and has to be avoided.

       I would be very pleased to help tool leaders/developers to fix it. Here you have the tools that need an i18n review, as soon as possible. During next few days I'll be working on this and fix it in trunk. I would appreciate any volunteer to help me.


assignment\assignment-tool\tool\src\java\org\sakaiproject\assignment\tool\AssignmentAction.java(6561): addAlert(state, rb.getString("gen.assig") + " " + a.getTitle() + " " + rb.getString("hassum"));
assignment\assignment-tool\tool\src\java\org\sakaiproject\assignment\tool\AssignmentAction.java(11076): addAlert(state, rb.getString("uploadall.size") + " " + max_file_size_mb + "MB " + rb.getString("uploadall.exceeded"));

authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(568): addAlert(state, rb.getString("realm.realm") + " " + id + " " + rb.getString("realm.notfound"));
authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(663): addAlert(state, rb.getString("realm.notpermis2") + " " + realm.getId());
authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(715): addAlert(state, rb.getString("realm.notpermis2") + " " + realm.getId());
authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(767): addAlert(state, rb.getString("realm.noProviderIdFound") + " " +  rb.getString("realm.edit.provider") + providers[i] + ". ");
authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(998): addAlert(state, rb.getString("realm.arole") + id + rb.getString("realm.defined"));
authz\authz-tool\tool\src\java\org\sakaiproject\authz\tool\RealmsAction.java(1058): addAlert(state, rb.getString("realm.arole") + id + rb.getString("realm.defined"));

content\content-tool\tool\src\java\org\sakaiproject\content\tool\AttachmentAction.java(133): VelocityPortletPaneledAction.addAlert(state, rb.getString("theupsiz") + " " + state.getAttribute(FILE_UPLOAD_MAX_SIZE)
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourceConditionsHelper.java(108): VelocityPortletPaneledAction.addAlert(state, rb.getString("conditions.condition.argument.outofrange") + " " + assignmentPointsString);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1347): addAlert(state, rb.getString("notpermis8") + " " + originalDisplayName + ". ");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1355): addAlert(state, rb.getString("someone") + " " + originalDisplayName);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1359): addAlert(state, rb.getString("pasteitem") + " " + originalDisplayName + " " + rb.getString("mismatch"));
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1363): addAlert(state, rb.getString("recursive") + " " + itemId);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1458): addAlert(state, rb.getString("notpermis8") + " " + originalDisplayName + ". ");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1466): addAlert(state, rb.getString("someone") + " " + originalDisplayName);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1470): addAlert(state, rb.getString("pasteitem") + " " + originalDisplayName + " " + rb.getString("mismatch"));
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1490): addAlert(state, rb.getString("recursive") + " " + itemId);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1617): addAlert(state, rb.getString("notpermis8") + " " + originalDisplayName + ". ");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1625): addAlert(state, rb.getString("notaddreso") + " " + originalDisplayName + " " + rb.getString("used2"));
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1641): addAlert(state, rb.getString("someone") + " " + originalDisplayName + ". ");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(1663): addAlert(state, rb.getString("pasteitem") + " " + originalDisplayName + " " + rb.getString("mismatch"));
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(2483): addAlert(state, rb.getString("notpermis2") + " " + id + ". " );
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(2487): addAlert(state," " + rb.getString("typeex") + " "  + id);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(5229): addAlert(state, rb.getString("notpermis14") + notDeleteNames);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(5325): addAlert(state, rb.getString("notpermis14") + notDeleteNames);
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(5505): addAlert(state, rb.getString("invalid.condition.argument.outside.range") + " " + item.getConditionAssignmentPoints() + ".");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesAction.java(6749): addAlert(state, rb.getString("invalid.condition.argument.outside.range") + " " + item.getConditionAssignmentPoints() + ".");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesHelperAction.java(926): addAlert(state, rb.getString("invalid.condition.argument.outside.range") + " " + newFolder.getConditionAssignmentPoints() + ".");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesHelperAction.java(1188): addAlert(state, rb.getString("invalid.condition.argument.outside.range") + " " + newFile.getConditionAssignmentPoints() + ".");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesHelperAction.java(1206): addAlert(state, contentResourceBundle.getString("conditions.condition.argument.outofrange") + " " + newFile.getConditionAssignmentPoints() + ".");
content\content-tool\tool\src\java\org\sakaiproject\content\tool\ResourcesHelperAction.java(1483): addAlert(state, contentResourceBundle.getString("conditions.condition.argument.outofrange") + " " + newFile.getConditionAssignmentPoints() + ".");

site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(930): addAlert(state, rb.getString("siteact.site") + " " + id + " " + rb.getString("siteact.notfou"));
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(940): addAlert(state, rb.getString("youdonot1") + " " + id);
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(1132): addAlert(state, rb.getString("sitact.youdonot3") + " " + site.getId());
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(1184): addAlert(state, rb.getString("sitact.youdonot3") + " " + site.getId());
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(2283): addAlert(state, rb.getString("sitedipag.alias") + " " + alias + " " + rb.getString("sitedipag.isinval"));
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(2295): addAlert(state, rb.getString("sitedipag.alias") + " " + alias + " " + rb.getString("sitedipag.exists"));
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(2298): addAlert(state, rb.getString("sitedipag.alias") + " " + alias + " " + rb.getString("sitedipag.isinval"));
site\site-tool\tool\src\java\org\sakaiproject\site\tool\AdminSitesAction.java(2301): addAlert(state, SessionManager.getCurrentSessionUserId() + rb.getString("sitedipag.alias.nopermission"));

site-manage\site-manage-tool\tool\src\java\org\sakaiproject\site\tool\SiteAction.java(5165): addAlert(state, rb.getString("java.delalias") + " " + aliasId + ". " + 

user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(568): addAlert(state, rb.getString("useact.youdonot1") + " " + id);
user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(576): addAlert(state, rb.getString("useact.somone") + " " + id);
user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(623): addAlert(state, rb.getString("useact.youdonot1") + " " + id);
user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(631): addAlert(state, rb.getString("useact.somone") + " " + id);
user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(733): addAlert(state, rb.getString("useact.youdonot2") + " " + user.getId());
user\user-tool\tool\src\java\org\sakaiproject\user\tool\UsersAction.java(792): addAlert(state, rb.getString("useact.youdonot2") + " " + user.getId());

web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(188): addAlert(state, rb.getString("unavailable") + "\n\n[" + e.getLocalizedMessage() + "]");
web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(193): addAlert(state, rb.getString("unavailable") + "\n\n[" + e.getLocalizedMessage() + "]");
web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(198): addAlert(state, rb.getString("unavailable") + "\n\n[" + e.getLocalizedMessage() + "]");
web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(377): addAlert(state, newChannelUrl + " " + rb.getString("invalidfeed"));
web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(383): addAlert(state, newChannelUrl + " " + rb.getString("invalidfeed"));
web\news-tool\tool\src\java\org\sakaiproject\news\tool\NewsAction.java(389): addAlert(state, newChannelUrl + " " + rb.getString("invalidfeed"));

       Thank you very much in advance.

Dr. David Roldán Martínez
Sakai QA lead for Internationalization
Universidad Politécnica de Valencia, Spain








More information about the i18n mailing list