[Contrib: Evaluation System] Errors/Failures in unit tests

[Matthew Jones]

Which version of java are you compiling with? With 1.7.0_21 it's giving 2
repeatable failures. I tried to upgrade the junit in impl to make it more
predictable (https://jira.sakaiproject.org/browse/KNL-1064) and it does
help, but it's still causing failures with either the default and
name_ascending modes.

Results :

Failed tests:

testGetEvaluationsForOwnerAndGroups(org.sakaiproject.evaluation.dao.EvaluationDaoImplTest)

testGetViewableGroupsForEvalAndUserByRole(org.sakaiproject.evaluation.logic.ReportingPermissionsImplTest)

Tests run: 274, Failures: 2, Errors: 0, Skipped: 0



On Tue, Jul 16, 2013 at 1:15 PM, Aaron Zeckoski <azeckoski at unicon.net>wrote:

> I don't see any failures in the evals tests on trunk myself but
> generally speaking, a patch which causes test failures would be
> rejected.
>
> Tests run: 274, Failures: 0, Errors: 0, Skipped: 0
> ...
> [INFO] Sakai Evaluation Project .......................... SUCCESS [6.854s]
> [INFO] Sakai Evaluation API .............................. SUCCESS [2.958s]
> [INFO] Sakai Evaluation Impl ............................. SUCCESS
> [1:25.506s]
> [INFO] Sakai Evaluation Pack ............................. SUCCESS [3.177s]
> [INFO] Sakai Evaluation Tool ............................. SUCCESS
> [52.914s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 2:31.940s
> [INFO] Finished at: Tue Jul 16 13:15:12 EDT 2013
>
> -AZ
>
>
> On Tue, Jul 16, 2013 at 11:54 AM, Brian Jones <bjones86 at uwo.ca> wrote:
> > Hi,
> >
> > I'm currently preparing a patch to submit to the community for new
> > functionality in the evalsys, but I noticed that there are several unit
> > tests that report either errors or failures during the build.
> >
> > I'm developing the patch against trunk of evalsys, and checked to see if
> the
> > same failures are reported on a stock check-out of trunk; which they
> are. It
> > reports the same two tests as failing, but in my modified branch there
> are a
> > bunch more which report 'errors' rather than 'failures'.
> >
> > Should I be concerned about this with regards to submitting the patch to
> the
> > community? Should I take the time to fix the tests that are in error?
> Should
> > I ignore the ones that are in 'failure' as they seem to also fail in the
> > stock trunk?
> >
> > Or maybe I should comment them out and submit the patch with that as
> well?
> > Any input will be helpful!
> >
> > Thanks,
> >
> > Brian Jones
> > Applications Development
> > Information Technology Services
> > Support Services Building, Room 4326
> > Western University
> > (519) 661-2111 x86969
> > bjones86 at uwo.ca
> >
> >
> >
> > _______________________________________________
> > evaluation mailing list
> > evaluation at collab.sakaiproject.org
> > http://collab.sakaiproject.org/mailman/listinfo/evaluation
> >
> > TO UNSUBSCRIBE: send email to
> evaluation-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
>
>
> --
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
> _______________________________________________
> evaluation mailing list
> evaluation at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>
> TO UNSUBSCRIBE: send email to
> evaluation-unsubscribe at collab.sakaiproject.org with a subject of
> "unsubscribe"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/evaluation/attachments/20130716/f980da24/attachment.html