[Contrib: Evaluation System] Question about reopening evaluation and stop-date

[Matthew Jones]

1) We had an issue where an instructor couldn't re-open an evaluation that
was "apparently closed" come up. The problem was that it past the "due and
stop dates" but not yet viewable. (For another week, for whatever reason)

In the code it has:

                // check if already active, do nothing if not closed
                if (EvalUtils.checkStateAfter(currentEvalState,
EvalConstants.EVALUATION_STATE_CLOSED, false)) {

However the state order is      ** States: Partial -> InQueue -> Active ->
GracePeriod -> Closed -> Viewable (-> Deleted)*

Does anyone else think that it should be "checkStateAfter
EVALUATION_STATE_GRACEPERIOD ", which would catch the closed and viewable
states?

2) In the administration interface you can set the option
" Use stop date (grace period) for evaluations, otherwise just use the due
date "

If later you decide to remove this, all of the stop dates are "NULL" in the
database, and the UI looks kind of funky for displaying this field on
previous evaluations.

It seems like it this is enabled either two things should happen.

  - The system should update the database and set all STOP_DATE values that
are NULL to be equal to the DUE_DATE.
  - If the STOP_DATE is NULL and this option is selected, display the
DUE_DATE instead (instead of an empty area, incorrect date)

I didn't want to file these as issues in-case there was a reason for them,
but would be happy to write them up.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/evaluation/attachments/20120430/b78a127f/attachment.html