[Contrib: Evaluation System] SQL conversion scripts fail

[Jim Eng]

I decided that trying to track down each change in the hibernate mappings was too much work and prone to errors. 

Instead, I used the maven ddl goal to regenerate the ddl scripts.  I will commit the revised scripts to trunk of evaluation.  That will make the ddl scripts correct for 1.4 but not for 1.3.  Next I will use a diff between the current oracle ddl script in subversion and the newly generated script to identify changes between 1.2 and 1.4 that are not already in the conversion scripts.  I will add those changes to the 1.3 to 1.4 oracle conversion script.  Again, that will help people wanting to go from 1.2 to 1.4 but it won't help people going from 1.2 to 1.3.  And it won't help people using database vendors other than oracle.      

It also doesn't deal with insert's, such as adding new default property settings.  We got errors on startup related to some missing config values.  Unfortunately the error message does not identify which properties are missing.  

Someone using another vendor or someone wanting to get a conversion script for 1.2 to 1.3 could do the process outlined above based on the 1.3 release.  If you do that, I hope you will commit the changes to the 1.3.x branch.

I'd still like to get a commitment from other developers in this project that any future changes related to the database will be reflected in the hibernate mapping files, the DDL files and the conversion scripts, not just the hibernate mapping files. That has been the policy in the sakai community since day one, and I think it should be the policy for evalsys as well. 

If someone has another suggestion for how we can deal with this issue, I'd be glad to hear it.  

Thanks.

Jim


On Sep 30, 2011, at 9:18 AM, Jim Eng wrote:

> It looks like the DDL files were added in rev 49590, and the only updates made to them were done by Nicola and me.  I will work through changes to the HBM files since rev 49590 and try to get them into the DDL scripts and the conversion scripts.  
> 
> I'd like to get a commitment from other people in this project that any future changes related to the database will be reflected in the hibernate mapping files, the DDL files and the conversion scripts.   
> 
> Thanks.
> 
> Jim
> 
> 
> On Sep 30, 2011, at 9:01 AM, Jim Eng wrote:
> 
>> We tried the Oracle conversion scripts to upgrade table from evalsys 1.2.x to 1.4.x (i.e. trunk).  This involves running two scripts -- from 1.2 to 1.3 and from 1.3 to 1.4.  After the conversion, the evaluation tool fails with a nasty stack trace in the UI.  The immediate problem is that the SQL to create the EVAL_ADMIN table is not in either conversion script.  It's also not in the DDL files.  I have created a JIRA ticket for that (http://bugs.sakaiproject.org/jira/browse/EVALSYS-1142) and I will track this down and add the SQL for the EVAL_ADMIN table to the various DDL and conversion files.  
>> 
>> But this raises a question: Are there any other critical DDL statements missing from the SQL scripts?  
>> 
>> I am going to try to track down changes to HBM files in evalsys to see if any of them were not accompanied by changes to the SQL files.  But I'd like help.  If you know of any hibernate changes that were not also included in the SQL, please let me know.  
>> 
>> Thanks.
>> 
>> Jim 
>> 
>> _______________________________________________
>> evaluation mailing list
>> evaluation at collab.sakaiproject.org
>> http://collab.sakaiproject.org/mailman/listinfo/evaluation
>> 
>> TO UNSUBSCRIBE: send email to evaluation-unsubscribe at collab.sakaiproject.org with a subject of "unsubscribe"
>> 
>> 
> 
> 
>