[Contrib: Evaluation System] EVALSYS-1072 - Reports showing response rate of entire evaluation, rather than selected groups

[Will Humphries]

Hey everyone,

We found (and fixed) a reporting issue this Fall. I want to make sure 
this seems like a definite bug to others.

https://jira.sakaiproject.org/browse/EVALSYS-1072

An evaluation is assigned to 5 groups, and each group gets 15/20 
responses. If a report is generated for 2 of those groups, the PDF and 
XLS reports will show 80/100 responses. We feel they should show 30/40 
responses (just those for the 2 reported-on groups), and included a 
patch that does this. If the report is generated for all 5 groups, it 
will still show the overall response rate.

Does anyone have a local use case where they would not want to show the 
response rate for just the groups the report is on?

Thanks for any feedback. Assuming everyone agrees this is a bug, the 
code change is small (2 lines) and I'm asking it be included in trunk 
and 1.3. From our users' perspective, this was a major bug as it 
prevented them from determining response rates for their courses.

-Will