[cle-release-team] SAK-22619 questions

[Sam Ottenhoff]

Thanks. I merged both commits into 2.9.x earlier tonight.

--Sam

On Mon, Sep 24, 2012 at 5:09 PM, Aaron Zeckoski <azeckoski at unicon.net>wrote:

> OK, this is ready for some verification. I went a slightly different
> direction after reviewing the code and thinking about it a little bit
> more. Check out the ticket for details.
> https://jira.sakaiproject.org/browse/SAK-22619
> :-)
> -AZ
>
>
> On Fri, Sep 21, 2012 at 1:07 PM, Matthew Jones <matthew at longsight.com>
> wrote:
> > Yea, there is a patch on the ticket. See this is why I asked, I knew the
> > property didn't make sense!
> >
> > It is entirely in EntityBatchHandler
> >
> > So it should be entitybroker.batch.disable (or
> > entitybroker.direct.batch.disable) not direct by itself! ;)
> >
> > Thanks!
> >
> > On Fri, Sep 21, 2012 at 12:38 PM, Aaron Zeckoski <azeckoski at unicon.net>
> > wrote:
> >>
> >> Aren't you just disabling the batch part? It seems like maybe the name
> >> should make that more clear.
> >> Is there a patch on the ticket or commit I can take a look at? I'm out
> at
> >> the moment but will look when I get back.
> >> -AZ
> >>
> >> On Sep 21, 2012 12:16 PM, "Matthew Jones" <matthew at longsight.com>
> wrote:
> >>>
> >>> Hi Aaron,
> >>>
> >>> As you suggested, I spent about a half hour on SAK-22619 and got it
> >>> working. I put the check in handleBatch and just made it print an info
> if it
> >>> was wrong. I created a property "entitybroker.disable.direct" .
> >>>
> >>> https://jira.sakaiproject.org/browse/SAK-22619
> >>>
> >>> Two questions I had though:
> >>>
> >>> 1) Is the name for the property okay? I also set the default to be
> >>> disabled (true)
> >>> 2) I didn't see a bean already for EntityBatchHandler and saw that
> other
> >>> classes were being passed in from EntityHandlerImpl and didn't want to
> mess
> >>> up anything, so just used ComponentManger cover. This seem okay? I
> left the
> >>> spring setter in there though, but didn't count on it being set.
> >>>
> >>> Thanks!
> >>>
> >>> -Matthew
> >>>
> >>> _______________________________________________
> >>> cle-release-team mailing list
> >>> cle-release-team at collab.sakaiproject.org
> >>> http://collab.sakaiproject.org/mailman/listinfo/cle-release-team
> >>>
> >
> >
> > _______________________________________________
> > cle-release-team mailing list
> > cle-release-team at collab.sakaiproject.org
> > http://collab.sakaiproject.org/mailman/listinfo/cle-release-team
> >
>
>
>
> --
> Aaron Zeckoski - Software Architect - http://tinyurl.com/azprofile
> _______________________________________________
> cle-release-team mailing list
> cle-release-team at collab.sakaiproject.org
> http://collab.sakaiproject.org/mailman/listinfo/cle-release-team
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/cle-release-team/attachments/20120924/52e627a8/attachment-0006.html