[cle-release-team] [Sakai Jira] Commented: (SAK-21742) Keyword in subject is not substituted with actual value

[Yuki Yamada (JIRA)]

    [ https://jira.sakaiproject.org/browse/SAK-21742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=153881#comment-153881 ] 

Yuki Yamada commented on SAK-21742:
-----------------------------------

There is a difference between site-manage and reset-pass about processing of the email template.
And, this issue is about getSubject() or getRenderedSubject().

site-manage:
sitemanage.notifyNewUserEmail and sitemange.notifyAddedParticipant are processed with calling getRenderedSubject() in https://source.sakaiproject.org/svn/site-manage/trunk/site-manage-impl/impl/src/java/org/sakaiproject/sitemanage/impl/ETSUserNotificationProviderImpl.java .

reset-pass:
validate.newUser is processed with calling EmailTemplateService#sendRenderedMessages() in https://source.sakaiproject.org/svn/reset-pass/trunk/account-validator-impl/src/java/org/sakaiproject/accountvalidator/logic/impl/ValidationLogicImpl.java .
And, EmailTemplateService#sendRenderedMessages() is calling getSubject(). Therefore, I think that we should modify it to getRenderedSubject() within EmailTemplateService.

> Keyword in subject is not substituted with actual value
> -------------------------------------------------------
>
>                 Key: SAK-21742
>                 URL: https://jira.sakaiproject.org/browse/SAK-21742
>             Project:  Sakai CLE
>          Issue Type: Bug
>          Components: Email Template Service
>    Affects Versions: 2.9.0-b01
>         Environment: sakai.properties: siteManage.validateNewUsers=true
>            Reporter: Yuki Yamada
>            Assignee: David Horwitz
>         Attachments: EmailTemplateServiceImpl.patch.txt, smtpDebug.PNG
>
>
> "validate.newUser" template is using ${localSakaiName} in the subject. Its template is from Account Validation tool.
> However, ${localSakaiName} is not substituted with actual value.
> See attched smtpDebug.PNG. It is the console screen when smtpDebug at org.sakaiproject.email.api.EmailService=true is set up in sakai.properties. The email is sent with ${localSakaiName}.
> Steps to reproduce:
> 1. Start Sakai with siteManage.validateNewUsers=true in sakai.properties to use Account Validation tool.
> 2. Log in to Sakai, and move to Site Info.
> 3. Select Add Participants link.
> 4. Input Email Address of Non-official Participant, and push Continue button.
> 5. Choose a role, and push Continue button.
> 6. Choose "Send Now", and push Continue button.
> 7. Push Finish button. Then, the email is sent.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira