[cle-release-team] Blocker: Portal sometimes redirects to mobile portal

[Steve Swinsburg]

Hello,

The only thing that changed was a session param from is_wireless_device to is_mobile_device. I scanned the code to check that wasn't in use elsewhere. The method is now also tied to your session so that sounds more likely since it looks like it happens when you time out. Strange. Maybe just a force recheck is all that is needed.

I didn't intend this for 2.9, but since the changes were only in the portal it should have been a safe merge.

I've been out of action sick all week and am still a bit ill, but i'll try to test this soon.

Cheers,
S

Sent from my iPad

On 16/08/2012, at 13:23, Matthew Jones <matthew at longsight.com> wrote:

> Hi Steve!
> 
> I'm not sure if you're tuned into this blocker : https://jira.sakaiproject.org/browse/SAK-22484
> 
> But I my first suspicion would be it was caused by when we did the recent merge of portal trunk into 2.9.x and picked up the WURFL->MobileESP changes as a lot of folks are reporting it recently. (https://jira.sakaiproject.org/browse/SAK-21334)
> 
> So my questions:
> 1) Since you have the most experience with this, do you know of anything you might have removed (caching, some session check) or something missing elsewhere that might have caused this regression?
> 2) Did you intend for this for 2.9?
>  - If not, perhaps we should just revert it and see if it fixes it, unless you think you might be able to fix it.
> 
> I'm not sure if I'll have the cycles in the week to look into this, but it seems like something we should have a decision to either attempt to fix or revert in 2.9.
> 
> I'm a strong believer of getting rid of WURFL and also improving the mobile experience and think this would be great, but maybe for 2.9.1 (unless it has a quick fix). Ideally we'd like to clean up all of the blockers by the end of August and this is the one I have the most concern about.
> 
> Thanks!
> 
> -Matthew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://collab.sakaiproject.org/pipermail/cle-release-team/attachments/20120816/ee0766fa/attachment-0006.html